From ed247b9eea1edc009774cef38c5edbb8de2f9236 Mon Sep 17 00:00:00 2001 From: Rehili Ghazwa Date: Sat, 7 Feb 2026 22:20:59 +0100 Subject: [PATCH 1/2] fix filter value --- .../global-filter/use-computation-column-filters.ts | 12 ++++++++++-- .../common/update-computation-columns-filters.ts | 2 +- 2 files changed, 11 insertions(+), 3 deletions(-) diff --git a/src/components/results/common/global-filter/use-computation-column-filters.ts b/src/components/results/common/global-filter/use-computation-column-filters.ts index 3d55c5f32b..78a587f1fd 100644 --- a/src/components/results/common/global-filter/use-computation-column-filters.ts +++ b/src/components/results/common/global-filter/use-computation-column-filters.ts @@ -21,13 +21,19 @@ function toColumnFilterInfos(infos: ComputationResultColumnFilterInfos[] | null) } return infos.flatMap(mapColumnFilters); } - +function parseFilterValue(filterValue: string) { + const parsed = JSON.parse(filterValue); + if (!Array.isArray(parsed)) { + return parsed; + } + return parsed.flatMap((v) => (typeof v === 'string' ? v.split(',').map((s) => s.trim()) : v)); +} function mapColumnFilters({ columnId, columnFilterInfos }: ComputationResultColumnFilterInfos): FilterConfig[] { const filters = Array.isArray(columnFilterInfos) ? columnFilterInfos : [columnFilterInfos]; return filters.map((filter) => ({ column: columnId, - value: filter.filterValue, + value: parseFilterValue(filter.filterValue), type: filter.filterType, dataType: filter.filterDataType, tolerance: filter.filterTolerance ?? undefined, @@ -42,6 +48,8 @@ export function useComputationColumnFilters(filterType: FilterType, computationS studyUuid && getComputationResultColumnFilters(studyUuid, filterType, computationSubType).then((infos) => { const filters = toColumnFilterInfos(infos); + console.log('===========================toColumnFilterInfos', filters); + dispatch(updateColumnFiltersAction(filterType, computationSubType, filters)); }); }, [dispatch, studyUuid, filterType, computationSubType]); diff --git a/src/components/results/common/update-computation-columns-filters.ts b/src/components/results/common/update-computation-columns-filters.ts index 4bf3aa3106..e07226d433 100644 --- a/src/components/results/common/update-computation-columns-filters.ts +++ b/src/components/results/common/update-computation-columns-filters.ts @@ -29,7 +29,7 @@ export const updateComputationColumnsFilters = ( ? { filterDataType: filter?.dataType, filterType: filter?.type, - filterValue: filter?.value, + filterValue: JSON.stringify(filter.value), filterTolerance: filter?.tolerance, } : null, From a578bc38f8362fdadb9f6b0b7b9d13883b76c0c9 Mon Sep 17 00:00:00 2001 From: Rehili Ghazwa Date: Mon, 9 Feb 2026 15:28:40 +0100 Subject: [PATCH 2/2] clean console log --- .../common/global-filter/use-computation-column-filters.ts | 2 -- .../results/common/update-computation-columns-filters.ts | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/components/results/common/global-filter/use-computation-column-filters.ts b/src/components/results/common/global-filter/use-computation-column-filters.ts index 78a587f1fd..9e60ca1a2f 100644 --- a/src/components/results/common/global-filter/use-computation-column-filters.ts +++ b/src/components/results/common/global-filter/use-computation-column-filters.ts @@ -48,8 +48,6 @@ export function useComputationColumnFilters(filterType: FilterType, computationS studyUuid && getComputationResultColumnFilters(studyUuid, filterType, computationSubType).then((infos) => { const filters = toColumnFilterInfos(infos); - console.log('===========================toColumnFilterInfos', filters); - dispatch(updateColumnFiltersAction(filterType, computationSubType, filters)); }); }, [dispatch, studyUuid, filterType, computationSubType]); diff --git a/src/components/results/common/update-computation-columns-filters.ts b/src/components/results/common/update-computation-columns-filters.ts index e07226d433..9c6664ff75 100644 --- a/src/components/results/common/update-computation-columns-filters.ts +++ b/src/components/results/common/update-computation-columns-filters.ts @@ -29,7 +29,7 @@ export const updateComputationColumnsFilters = ( ? { filterDataType: filter?.dataType, filterType: filter?.type, - filterValue: JSON.stringify(filter.value), + filterValue: JSON.stringify(filter?.value), filterTolerance: filter?.tolerance, } : null,