Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C-API should allow periodic calculations with any method #172

Closed
awvwgk opened this issue Apr 20, 2020 · 0 comments · Fixed by #222
Closed

C-API should allow periodic calculations with any method #172

awvwgk opened this issue Apr 20, 2020 · 0 comments · Fixed by #222
Labels
C-API Concerns the ISO-C layer

Comments

@awvwgk
Copy link
Member

awvwgk commented Apr 20, 2020

Is your feature request related to a problem? Please describe.
The API is currently aware of boundary conditions, which requires an API change for every method that gets new boundary conditions.

Describe the solution you'd like
Generally it would be much easier to separate the calculator from the structure information as much as possible and just reject invalid input (e.g. due to missing implementation of the boundary conditions) by returning an error code.

Describe alternatives you've considered
The alternative is go with the current solution and implement redundant bindings for the same methods.

Additional context
This change might will break the complete API compatibility with previous versions.

@awvwgk awvwgk added python C-API Concerns the ISO-C layer labels Apr 20, 2020
@awvwgk awvwgk linked a pull request May 22, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-API Concerns the ISO-C layer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant