Fix #113 - the class loading should also catch linkage errors, which can potentially arise in very valid situations.

Author: groboclown

CHANGES.md

@@ -1,5 +1,19 @@
 # IDEA Community VCS Integration for Perforce
 
+## ::v0.7.9::
+
+### Overview
+
+* Bug fixes.
+
+### Details
+
+* Bug fixes.
+    * Android Studio and other non-JRE 8 IDEs can fail to load the
+      plugin.  Now, all the class loading errors should be caught
+      when loading the compatibility libraries. (#113)
+
+
 ## ::v0.7.8::
 
 ### Overview

idea-compat/src/net/groboclown/idea/p4ic/compat/CompatFactoryLoader.java

@@ -82,19 +82,21 @@ public static CompatFactory loadCompatFactory() {
     private static CompatFactory loadCompatFactory(@NotNull String apiVersion, ClassLoader[] loaders) {
         CompatFactory best = null;
         for (ClassLoader loader: loaders) {
-            try
-            {
-                for (CompatFactory factory : ServiceLoader.load(CompatFactory.class, loader))
-                {
-                    if (isCompatible(apiVersion, factory) && isBetterVersion(best, factory))
-                    {
+            try {
+                for (CompatFactory factory : ServiceLoader.load(CompatFactory.class, loader)) {
+                    if (isCompatible(apiVersion, factory) && isBetterVersion(best, factory)) {
                         best = factory;
                     }
                 }
-            }
-            catch (ServiceConfigurationError e)
-            {
+            } catch (ServiceConfigurationError e) {
                 LOG.error(e);
+            } catch (LinkageError e) {
+                // bug #113
+                // The IDE classes aren't matching up with the expected signatures,
+                // the classes are compiled with an incompatible JRE,
+                // or any number of other issues that shouldn't stop
+                // the plugin from loading.
+                LOG.warn(e);
             }
         }
         return best;

plugin/META-INF/plugin.xml

@@ -1,11 +1,19 @@
 <idea-plugin version="2">
     <name>Perforce IDEA Community Integration</name>
     <id>PerforceIC</id>
-    <version>0.7.8</version>
+    <version>0.7.9</version>
     <idea-version since-build="IC-135.1286"/>
     <category>VCS Integration</category>
     <change-notes><![CDATA[
         <ol>
+            <li><em>0.7.9</em>
+                <ol>
+                  <li>Android Studio and other non-JRE 8 IDEs can
+                  fail to load the plugin.  Now, all the class
+                  loading errors should be caught when loading the
+                  compatibility libraries.</li>
+                </ol>
+            </li>
             <li><em>0.7.8</em>
                 <ol>
                   <li>Initial project VCS setup no longer
@@ -17,36 +25,6 @@
                   reported by the server.</li>
                 </ol>
             </li>
-            <li><em>0.7.7</em>
-                <ol>
-                  <li>Fixed an issue where the user may be
-                  told repeatedly that their password is wrong,
-                  even though it's correct.</li>
-                </ol>
-            </li>
-            <li><em>0.7.6</em>
-                <ol>
-                    <li>Switched to using MD5 hash codes when comparing if a file is actually
-                    edited but not checked out.</li>
-                    <li>Added user preference to disable server-side file comparison when checking
-                    for edited but not checked out status.</li>
-                    <li>Added user preference for switching between showing revision numbers and
-                    changelist numbers.</li>
-                    <li>Fixed compilation errors against the latest IDEA version of the
-                    primary plugin.  This may result in you needing to reload your
-                    Perforce configuration.</li>
-                    <li>Should now always authenticate once the server reports that the
-                    user requires authentication.  This should also fix the
-                    issue where the plugin can continuously ask for the password;
-                    this could happen if you use the configuration file without
-                    specifying an authentication ticket or a password.</li>
-                    <li>Fixed a deadlock associated with initial startup when asking the
-                    user for the master IDEA password.</li>
-                    <li>Fixed submit issue where only the error would be reported;
-                    now, all messages are reported to the user.</li>
-                    <li>Fixed ignored tick marks (') in messages.</li>
-                </ol>
-            </li>
         </ol>
     ]]></change-notes>
     <description><![CDATA[