Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag — use "Close" icon instead of "FormClose" and update remove button sizes per Tag size #413

Closed
1 task done
taysea opened this issue Oct 21, 2024 · 1 comment
Closed
1 task done

Tag — use "Close" icon instead of "FormClose" and update remove button sizes per Tag size #413

taysea opened this issue Oct 21, 2024 · 1 comment
Assignees
@taysea

Comments

@taysea
Copy link
Collaborator

taysea commented Oct 21, 2024 •
edited
Loading

Design: https://www.figma.com/design/drD2ft9yyKcj1UUOL0LSnC/Theme-update?node-id=35-1094&node-type=frame&t=it0GZeSaQgeF4ms1-11

Current implementation: https://deploy-preview-4256--keen-mayer-a86c8b.netlify.app/components/tag?q=tag#removable

Deliverable:
@taysea
Copy link
Collaborator Author

taysea commented Oct 21, 2024

This update is dependent on grommet/grommet#7386

@taysea taysea changed the title Tag — use "Close" icon instead of "FormClose" but ensure appropriate size can be achieved Tag — use "Close" icon instead of "FormClose" and update remove button sizes per Tag size Oct 21, 2024
@taysea taysea self-assigned this Oct 21, 2024
@taysea taysea closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taysea taysea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taysea