-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata & Description in figma #3561
Comments
@ashifalinadaf is proceeding with just adding Keywords & links to the Ds site to top level components (not variants). We will avoid editing & publishing metadata on the following components until we consult @KennyAtHPE to uncover if there have been visual changes that need reviewed: (As these components currently show up in figma as having unpublished changes.)
|
Hey @KennyAtHPE can we schedule a call on Monday to review the components in the previous comment & see if visual changes have been made before we add and publish the metadata. @taysea @jcfilben, we have added keywords to our figma components, and would like to add the same terms as searchable metadata on the DS site. We need a bit of guidance on how best to approach this, we can use one component as a test case and then see if the work can be carried out by a designer & reviewed via pull request. |
Hey @SeamusLeonardHPE the terms can be added to this file: Agree on starting with just one component, opening a pull request and ensuring it is working correctly, then we can move forward from there. |
@SeamusLeonardHPE apologies, I will take a look today and review the unpublished changes to those components you mentioned previously. |
@SeamusLeonardHPE reviewed the components. Feel free to publish, I do not see any visual changes—a reminder to include a message explaining the change and who to contact if there are any issues. Side note, we may have to change to using the branching feature to avoid similar issues in the future. The branching feature provides a side-to-side comparison of the old and new versions of components. It's tough to see how a component has changed otherwise. |
@KennyAtHPE thanks for the clarification, I will publish the remaining component with metadata. |
Added meta data to all the component in Figma file, except 'data table component' (as there are many smaller components). Created a PR to test the discoverability on DS site for 'selectmultiple' component #3566 @jcfilben @taysea if you have a look and merge it. |
@ashifalinadaf thank you for adding the metadata for those components, did you already go ahead and publish those changes? If not, feel free to publish since this should not be breaking any existing instances. |
Subsequent task,
|
Completed adding metadata to the components PR #3569, @taysea please have a look and merge if all goes well. All DS figma components that have not been updated have been coloured light yellow with comments, these are either need refactor or without published component. @SeamusLeonardHPE Updated on master sheet Currently working on adding metadata to the templates. |
PR for adding keywords to the Templates - #3571 @taysea @SeamusLeonardHPE |
Closed as complete. All non checked items in issues are either - components that have been deprecated as unsuitable to figma |
Goal: Aid discoverability of existing components, and design patterns in the guidance site.
Approach: Add metadata that includes alternative names & usage descriptions to both figma components (and variants) as well as adding searchable metadata to DS site pages.
Suggested keyword data has been added to linked excel sheet:
Link to audit research
Deliverable 1: Guidance & Metadata template
draft guidance/discovery
Deliverable 2: Individual components & pages to update.
Questions about figma "description" and link fields
The text was updated successfully, but these errors were encountered: