Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program can load XBIN files of uneven width, but not save them #15

Open
TheGreenHerring opened this issue Sep 27, 2023 · 0 comments
Open

Comments

@TheGreenHerring
Copy link

Like with BIN format, attempting to save an XBIN file of uneven width fails silently. However, in this case, the inability to save XBIN files of uneven width is itself a bug: the XBIN format directly stores the intended width in two bytes (rather than storing half the intended width in one byte like the SAUCE BinaryText width field) explicitly enabling images of uneven width (and the specification advises programmers of art viewers in the DOS era, where video memory always had an even length, to write special code to handle the case of an odd-width image).

The other element of the bug is that loading an odd-width image works just fine. The program will load and display the image at the correct width... but will then be unable to save any changes made to it.

This bug is especially noticeable when the program is compared to PabloDraw, which will allow you to load and save XBIN images of uneven width without a fuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant