Provide a way to deploy new dags from github

[Sedward]

It had previously been discussed on slack that we could use the the git-sync sidecar for updating dags from github. The environment variables have already been added. We could add the git-sync sidecar to the scheduler, worker and web deployments. If this is done, do we make it an option in the values.yaml that has to be enabled?

[gsemet]

it is already done, what is the difference with the current git-sync script and settings in values.yaml?

[Sedward]

How does it currently work? I haven't used git-sync yet but I was expecting to see a sidecar in the deployments that use it like the example in their repo.

https://github.com/kubernetes/git-sync/blob/master/demo/config/pod.yaml#L9

[gsemet]

Read the read me. It is a gitsync launched in the container. Using a sidecar means sharing a folder. Which is also a valid use case

[Sedward]

OK I see it now. Is there a benefit to using this script inside the container vs the sidecar container from the kubernetes org? I thought it was somewhat of an anti-pattern to run more than one process in a container.

[gsemet]

On we need to ensure a share path. If you adapt the conf with an optional sidecar gitsync it can be good to have.

[Jonathan34]

I see the value git_sync_enabled but i can't see where it is used in the charts. which makes me think this chart only support embedded dags via docker image?

[gsemet]

yes, it does not work anymore, I did not took the time to restore it, and it has many issues that need to be fixed