Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Region Control with Hook nodes #14

Closed
duchamps0305 opened this issue Jan 2, 2025 · 1 comment
Closed

Using Region Control with Hook nodes #14

duchamps0305 opened this issue Jan 2, 2025 · 1 comment

Comments

@duchamps0305
Copy link

Hi, I've been using the new hook loras and prop set combine nodes from the comfy team to do regional conditioning while waiting for for the new update for the ControlAltAI nodes, I was wondering if there is a way to use the great bbox masking system you made using the comfy nodes? My biggest issue right now is creating good enough masks with other nodes while your system seemed to be really promising.

https://blog.comfy.org/p/masking-and-scheduling-lora-and-model-weights

@gseth
Copy link
Owner

gseth commented Jan 2, 2025

I have tried for the last whole month. The issue is that each Lora key is different, and they don't match the spatial control level in the flux pipeline.

I made two different pipelines and around 20 new nodes, tried all combinations, and kept running into issues.

The basic concept would be to take the mask and convert it to latent space, which is successfully done. The comfy default lora hook doesn't work. So I created a new lora hook set it up set clip hook. We then forward that to region mask conditioning from pipeline. Which was modified to hold the dict values of the Conditioning bbox, mask and lora. We then pass everything to the flux attention control.

Over here the issue happens. I end up with Mis Match issues. I cannot fix it.

For this we need to completely reverse engineer the flux + lora interaction. which will take months and by that time we will have something new, unless the team at black forest labs just advise on how to proceed at this stage.

The simplest way is a Left and right Region, Lora, but then that's not this pipeline, and the results are underwhelming. To get LoRA on this level of spatial control would be great. I don't mind sharing the actual logic in the flux attention, if someone can take a look at it, some one who has a deeper knowledge and solve the issue.

image
image
image

New Nodes plus test workflow (not working: https://drive.google.com/file/d/1TYCH2q_BARjZh4690lGYgOFy7IX5L4xW/view?usp=sharing

At this point I have given up, unless someone can help here.

@gseth gseth assigned gseth and unassigned gseth Jan 2, 2025
@gseth gseth added enhancement New feature or request and removed enhancement New feature or request labels Jan 2, 2025
@gseth gseth closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants