From 3c88b37a58c503be658fee0383ad86200b4ce6dc Mon Sep 17 00:00:00 2001
From: Guillaume Smet <guillaume.smet@gmail.com>
Date: Wed, 5 Jun 2024 10:05:57 +0200
Subject: [PATCH] Make -Dquickly a bit faster

Instantiation the plugins can actually be costly when we have so many
artifacts.
For now, I have only applied this trick where it makes a great
difference and has a low cost of maintenance.
We could also do it for Surefire.

Per a discussion with @ppalaga.
---
 build-parent/pom.xml                                | 3 ++-
 core/deployment/pom.xml                             | 1 +
 devtools/maven/pom.xml                              | 1 +
 extensions/observability-devservices/pom.xml        | 1 +
 extensions/panache/panache-mock/pom.xml             | 1 +
 extensions/pom.xml                                  | 1 +
 extensions/security/test-utils/pom.xml              | 1 +
 independent-projects/arc/pom.xml                    | 1 +
 independent-projects/bootstrap/pom.xml              | 1 +
 independent-projects/extension-maven-plugin/pom.xml | 1 +
 independent-projects/junit5-virtual-threads/pom.xml | 1 +
 independent-projects/parent/pom.xml                 | 1 +
 independent-projects/qute/pom.xml                   | 1 +
 independent-projects/resteasy-reactive/pom.xml      | 1 +
 independent-projects/tools/pom.xml                  | 1 +
 integration-tests/kubernetes-client/pom.xml         | 1 +
 integration-tests/openshift-client/pom.xml          | 1 +
 integration-tests/pom.xml                           | 1 +
 integration-tests/virtual-threads/pom.xml           | 1 +
 pom.xml                                             | 5 +++++
 tcks/pom.xml                                        | 1 +
 test-framework/kubernetes-client/pom.xml            | 1 +
 test-framework/openshift-client/pom.xml             | 1 +
 test-framework/pom.xml                              | 1 +
 24 files changed, 29 insertions(+), 1 deletion(-)

diff --git a/build-parent/pom.xml b/build-parent/pom.xml
index 2879d9b28df6e..a0655685ddad7 100644
--- a/build-parent/pom.xml
+++ b/build-parent/pom.xml
@@ -525,6 +525,7 @@
                     <executions>
                         <execution>
                             <id>enforce</id>
+                            <phase>${maven-enforcer-plugin.phase}</phase>
                             <configuration>
                                 <rules>
                                     <dependencyConvergence/>
@@ -679,7 +680,7 @@
                                 <ignoreSignaturesOfMissingClasses>true</ignoreSignaturesOfMissingClasses>
                                 <suppressAnnotations><annotation>**.SuppressForbidden</annotation></suppressAnnotations>
                             </configuration>
-                            <phase>compile</phase>
+                            <phase>${forbiddenapis-maven-plugin.phase}</phase>
                             <goals>
                                 <goal>check</goal>
                             </goals>
diff --git a/core/deployment/pom.xml b/core/deployment/pom.xml
index 367713725caf6..cd5fef3b67488 100644
--- a/core/deployment/pom.xml
+++ b/core/deployment/pom.xml
@@ -190,6 +190,7 @@
                 <executions>
                     <execution>
                         <id>enforce</id>
+                        <phase>${maven-enforcer-plugin.phase}</phase>
                         <goals>
                             <goal>enforce</goal>
                         </goals>
diff --git a/devtools/maven/pom.xml b/devtools/maven/pom.xml
index e29c8f896b6fa..c593bd56485e7 100644
--- a/devtools/maven/pom.xml
+++ b/devtools/maven/pom.xml
@@ -282,6 +282,7 @@
                 <executions>
                     <execution>
                         <id>enforce-quarkus-maven-plugin</id>
+                        <phase>${maven-enforcer-plugin.phase}</phase>
                         <configuration>
                             <rules>
                                 <bannedDependencies>
diff --git a/extensions/observability-devservices/pom.xml b/extensions/observability-devservices/pom.xml
index 972d9e41e83b7..c4e2140af2d71 100644
--- a/extensions/observability-devservices/pom.xml
+++ b/extensions/observability-devservices/pom.xml
@@ -37,6 +37,7 @@
                 <executions>
                     <execution>
                         <id>enforce</id>
+                        <phase>${maven-enforcer-plugin.phase}</phase>
                         <configuration>
                             <rules combine.self="override">
                                 <dependencyConvergence/>
diff --git a/extensions/panache/panache-mock/pom.xml b/extensions/panache/panache-mock/pom.xml
index d6db8863936a4..41b927dc79de5 100644
--- a/extensions/panache/panache-mock/pom.xml
+++ b/extensions/panache/panache-mock/pom.xml
@@ -54,6 +54,7 @@
                 <executions>
                     <execution>
                         <id>enforce</id>
+                        <phase>${maven-enforcer-plugin.phase}</phase>
                         <configuration>
                             <rules combine.self="override">
                                 <dependencyConvergence/>
diff --git a/extensions/pom.xml b/extensions/pom.xml
index fc029e26ab225..e346c10ba5479 100644
--- a/extensions/pom.xml
+++ b/extensions/pom.xml
@@ -228,6 +228,7 @@
                 <executions>
                     <execution>
                         <id>enforce</id>
+                        <phase>${maven-enforcer-plugin.phase}</phase>
                         <goals>
                             <goal>enforce</goal>
                         </goals>
diff --git a/extensions/security/test-utils/pom.xml b/extensions/security/test-utils/pom.xml
index bad909646287c..01f287aaa3857 100644
--- a/extensions/security/test-utils/pom.xml
+++ b/extensions/security/test-utils/pom.xml
@@ -65,6 +65,7 @@
                 <executions>
                     <execution>
                         <id>enforce</id>
+                        <phase>${maven-enforcer-plugin.phase}</phase>
                         <configuration>
                             <rules combine.self="override">
                                 <dependencyConvergence/>
diff --git a/independent-projects/arc/pom.xml b/independent-projects/arc/pom.xml
index 7fd37eb477a09..e275e4fab9c62 100644
--- a/independent-projects/arc/pom.xml
+++ b/independent-projects/arc/pom.xml
@@ -212,6 +212,7 @@
                     <executions>
                         <execution>
                             <id>enforce</id>
+                            <phase>${maven-enforcer-plugin.phase}</phase>
                             <configuration>
                                 <rules>
                                     <dependencyConvergence/>
diff --git a/independent-projects/bootstrap/pom.xml b/independent-projects/bootstrap/pom.xml
index 9aed6c21b79a5..0ecd15f6601bd 100644
--- a/independent-projects/bootstrap/pom.xml
+++ b/independent-projects/bootstrap/pom.xml
@@ -125,6 +125,7 @@
                     <executions>
                         <execution>
                             <id>enforce</id>
+                            <phase>${maven-enforcer-plugin.phase}</phase>
                             <configuration>
                                 <rules>
                                     <dependencyConvergence/>
diff --git a/independent-projects/extension-maven-plugin/pom.xml b/independent-projects/extension-maven-plugin/pom.xml
index cfa31fb462fbd..736338c86c1eb 100644
--- a/independent-projects/extension-maven-plugin/pom.xml
+++ b/independent-projects/extension-maven-plugin/pom.xml
@@ -92,6 +92,7 @@
                     <executions>
                         <execution>
                             <id>enforce</id>
+                            <phase>${maven-enforcer-plugin.phase}</phase>
                             <configuration>
                                 <rules>
                                     <dependencyConvergence/>
diff --git a/independent-projects/junit5-virtual-threads/pom.xml b/independent-projects/junit5-virtual-threads/pom.xml
index 64d0600d16887..b9e2a3e70b66a 100644
--- a/independent-projects/junit5-virtual-threads/pom.xml
+++ b/independent-projects/junit5-virtual-threads/pom.xml
@@ -97,6 +97,7 @@
                     <executions>
                         <execution>
                             <id>enforce</id>
+                            <phase>${maven-enforcer-plugin.phase}</phase>
                             <configuration>
                                 <rules>
                                     <dependencyConvergence/>
diff --git a/independent-projects/parent/pom.xml b/independent-projects/parent/pom.xml
index 71e87d2977668..945736f4e56d1 100644
--- a/independent-projects/parent/pom.xml
+++ b/independent-projects/parent/pom.xml
@@ -129,6 +129,7 @@
                 <executions>
                     <execution>
                         <id>enforce</id>
+                        <phase>${maven-enforcer-plugin.phase}</phase>
                         <goals>
                             <goal>enforce</goal>
                         </goals>
diff --git a/independent-projects/qute/pom.xml b/independent-projects/qute/pom.xml
index 2546e04d1484a..4c36b19a14c4e 100644
--- a/independent-projects/qute/pom.xml
+++ b/independent-projects/qute/pom.xml
@@ -129,6 +129,7 @@
                     <executions>
                         <execution>
                             <id>enforce</id>
+                            <phase>${maven-enforcer-plugin.phase}</phase>
                             <configuration>
                                 <rules>
                                     <dependencyConvergence/>
diff --git a/independent-projects/resteasy-reactive/pom.xml b/independent-projects/resteasy-reactive/pom.xml
index 76ccb42fe2ff2..2131e991e13ee 100644
--- a/independent-projects/resteasy-reactive/pom.xml
+++ b/independent-projects/resteasy-reactive/pom.xml
@@ -424,6 +424,7 @@
                     <executions>
                         <execution>
                             <id>enforce</id>
+                            <phase>${maven-enforcer-plugin.phase}</phase>
                             <configuration>
                                 <rules>
                                     <dependencyConvergence/>
diff --git a/independent-projects/tools/pom.xml b/independent-projects/tools/pom.xml
index db6d61ea88707..287b0bdc03f0f 100644
--- a/independent-projects/tools/pom.xml
+++ b/independent-projects/tools/pom.xml
@@ -227,6 +227,7 @@
                 <executions>
                     <execution>
                         <id>enforce</id>
+                        <phase>${maven-enforcer-plugin.phase}</phase>
                         <configuration>
                             <rules>
                                 <externalRules>
diff --git a/integration-tests/kubernetes-client/pom.xml b/integration-tests/kubernetes-client/pom.xml
index 6bfe1a68c3f93..3f7bd5bfd35b7 100644
--- a/integration-tests/kubernetes-client/pom.xml
+++ b/integration-tests/kubernetes-client/pom.xml
@@ -160,6 +160,7 @@
                 <executions>
                     <execution>
                         <id>enforce</id>
+                        <phase>${maven-enforcer-plugin.phase}</phase>
                         <goals>
                             <goal>enforce</goal>
                         </goals>
diff --git a/integration-tests/openshift-client/pom.xml b/integration-tests/openshift-client/pom.xml
index 51a3611fc79d3..a0b19a6b346e6 100644
--- a/integration-tests/openshift-client/pom.xml
+++ b/integration-tests/openshift-client/pom.xml
@@ -116,6 +116,7 @@
                 <executions>
                     <execution>
                         <id>enforce</id>
+                        <phase>${maven-enforcer-plugin.phase}</phase>
                         <goals>
                             <goal>enforce</goal>
                         </goals>
diff --git a/integration-tests/pom.xml b/integration-tests/pom.xml
index e5ce0e0a1076d..5a44f2591b35b 100644
--- a/integration-tests/pom.xml
+++ b/integration-tests/pom.xml
@@ -37,6 +37,7 @@
                 <executions>
                     <execution>
                         <id>enforce</id>
+                        <phase>${maven-enforcer-plugin.phase}</phase>
                         <goals>
                             <goal>enforce</goal>
                         </goals>
diff --git a/integration-tests/virtual-threads/pom.xml b/integration-tests/virtual-threads/pom.xml
index b5d560c9084c6..1f925deeacc95 100644
--- a/integration-tests/virtual-threads/pom.xml
+++ b/integration-tests/virtual-threads/pom.xml
@@ -51,6 +51,7 @@
                 <executions>
                     <execution>
                         <id>enforce</id>
+                        <phase>${maven-enforcer-plugin.phase}</phase>
                         <goals>
                             <goal>enforce</goal>
                         </goals>
diff --git a/pom.xml b/pom.xml
index e5aa78651d14b..69b70f2e144d4 100644
--- a/pom.xml
+++ b/pom.xml
@@ -60,6 +60,9 @@
         <skipDocs>false</skipDocs>
         <skip.gradle.tests>false</skip.gradle.tests>
 
+        <maven-enforcer-plugin.phase>validate</maven-enforcer-plugin.phase>
+        <forbiddenapis-maven-plugin.phase>verify</forbiddenapis-maven-plugin.phase>
+
         <owasp-dependency-check-plugin.version>9.0.7</owasp-dependency-check-plugin.version>
 
         <!-- Dependency versions -->
@@ -186,11 +189,13 @@
                 <skipITs>true</skipITs>
                 <skipDocs>true</skipDocs>
                 <enforcer.skip>true</enforcer.skip>
+                <maven-enforcer-plugin.phase>none</maven-enforcer-plugin.phase>
                 <skipExtensionValidation>true</skipExtensionValidation>
                 <skip.gradle.tests>true</skip.gradle.tests>
                 <invoker.skip>true</invoker.skip>   <!-- maven-invoker-plugin -->
                 <jbang.skip>true</jbang.skip> <!-- jbang-maven-plugin -->
                 <forbiddenapis.skip>true</forbiddenapis.skip> <!-- forbidden-apis maven plugin -->
+                <forbiddenapis-maven-plugin.phase>none</forbiddenapis-maven-plugin.phase>
                 <skipCodestartValidation>true</skipCodestartValidation>
                 <truststore.skip>true</truststore.skip>
             </properties>
diff --git a/tcks/pom.xml b/tcks/pom.xml
index f66fad28b6648..284143d1d6786 100644
--- a/tcks/pom.xml
+++ b/tcks/pom.xml
@@ -26,6 +26,7 @@
                 <executions>
                     <execution>
                         <id>enforce</id>
+                        <phase>${maven-enforcer-plugin.phase}</phase>
                         <goals>
                             <goal>enforce</goal>
                         </goals>
diff --git a/test-framework/kubernetes-client/pom.xml b/test-framework/kubernetes-client/pom.xml
index a3f667755e89a..dd147652f2d7f 100644
--- a/test-framework/kubernetes-client/pom.xml
+++ b/test-framework/kubernetes-client/pom.xml
@@ -75,6 +75,7 @@
                 <executions>
                     <execution>
                         <id>enforce</id>
+                        <phase>${maven-enforcer-plugin.phase}</phase>
                         <goals>
                             <goal>enforce</goal>
                         </goals>
diff --git a/test-framework/openshift-client/pom.xml b/test-framework/openshift-client/pom.xml
index ffafb665e64ed..2de4d36c34587 100644
--- a/test-framework/openshift-client/pom.xml
+++ b/test-framework/openshift-client/pom.xml
@@ -65,6 +65,7 @@
                 <executions>
                     <execution>
                         <id>enforce</id>
+                        <phase>${maven-enforcer-plugin.phase}</phase>
                         <goals>
                             <goal>enforce</goal>
                         </goals>
diff --git a/test-framework/pom.xml b/test-framework/pom.xml
index 30b57a897b382..888a8dd222928 100644
--- a/test-framework/pom.xml
+++ b/test-framework/pom.xml
@@ -59,6 +59,7 @@
                 <executions>
                     <execution>
                         <id>enforce</id>
+                        <phase>${maven-enforcer-plugin.phase}</phase>
                         <configuration>
                             <rules combine.self="override">
                                 <dependencyConvergence/>