Add PY_SSIZE_T_CLEAN to the build as necessary.

[amarchini01]

Looks like some changes are needed for the 64 bit build. Running this code against 3.8 gives the following warning when calling it.

DeprecationWarning: PY_SSIZE_T_CLEAN will be required for '#' formats

Used a filter override to fix it for now.

[pres2300]

This issue now results in an error with Python 3.10.

[parkerlreed]

Yeah no longer builds on 3.10

==> Starting build()...
/home/parker/.cache/paru/clone/python-crc16/src/crc16-0.1.1/setup.py:23: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
  from distutils.core import setup, Extension
running build
running build_py
creating build
creating build/lib.linux-x86_64-3.10
creating build/lib.linux-x86_64-3.10/crc16
copying python3x/crc16/test.py -> build/lib.linux-x86_64-3.10/crc16
copying python3x/crc16/crc16pure.py -> build/lib.linux-x86_64-3.10/crc16
copying python3x/crc16/__init__.py -> build/lib.linux-x86_64-3.10/crc16
running build_ext
building 'crc16._crc16' extension
creating build/temp.linux-x86_64-3.10
creating build/temp.linux-x86_64-3.10/src
gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -march=x86-64 -mtune=generic -O3 -pipe -fno-plt -march=x86-64 -mtune=generic -O3 -pipe -fno-plt -march=x86-64 -mtune=generic -O3 -pipe -fno-plt -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -fstack-clash-protection -fcf-protection -fPIC -I/usr/include/python3.10 -c src/_crc16module.c -o build/temp.linux-x86_64-3.10/src/_crc16module.o
gcc -pthread -shared -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions -Wp,-D_FORTIFY_SOURCE=2 -fstack-clash-protection -fcf-protection build/temp.linux-x86_64-3.10/src/_crc16module.o -L/usr/lib -o build/lib.linux-x86_64-3.10/crc16/_crc16.cpython-310-x86_64-linux-gnu.so
==> Starting check()...
EE.E
======================================================================
ERROR: test_basics (__main__.TestCRC16XModem)
Test basic functionality.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/parker/.cache/paru/clone/python-crc16/src/crc16-0.1.1/build/lib.linux-x86_64-3.10/crc16/test.py", line 58, in test_basics
    self.doBasics(crc16)
  File "/home/parker/.cache/paru/clone/python-crc16/src/crc16-0.1.1/build/lib.linux-x86_64-3.10/crc16/test.py", line 36, in doBasics
    self.assertEqual(module.crc16xmodem(b'123456789'), 0x31c3)
SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats

======================================================================
ERROR: test_basics_c (__main__.TestCRC16XModem)
Test basic functionality of the extension module.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/parker/.cache/paru/clone/python-crc16/src/crc16-0.1.1/build/lib.linux-x86_64-3.10/crc16/test.py", line 64, in test_basics_c
    self.doBasics(_crc16)
  File "/home/parker/.cache/paru/clone/python-crc16/src/crc16-0.1.1/build/lib.linux-x86_64-3.10/crc16/test.py", line 36, in doBasics
    self.assertEqual(module.crc16xmodem(b'123456789'), 0x31c3)
SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats

======================================================================
ERROR: test_big_chunks (__main__.TestCRC16XModem)
Test calculation of CRC on big chunks of data.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/parker/.cache/paru/clone/python-crc16/src/crc16-0.1.1/build/lib.linux-x86_64-3.10/crc16/test.py", line 77, in test_big_chunks
    self.assertEqual(_crc16.crc16xmodem(b'A' * 16 * 1024 * 1024), 0xbf75)
SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats

----------------------------------------------------------------------
Ran 4 tests in 0.022s

FAILED (errors=3)

[gtrafimenkov]

Hello! Sorry, I don't have capacity for maintaining this repository. Feel free to fork if you want. I am going to archive this repository.