perf(Concerns): improve error handling in setSoarBinary

- Refactor error handling in setSoarBinary method
- Combine file existence and executability checks
- Throw exception when file does not exist or is not executable

Author: guanguans

src/Concerns/HasSoarBinary.php

@@ -30,12 +30,12 @@ public function getSoarBinary(): string
 
     public function setSoarBinary(string $soarBinary): self
     {
-        if (!file_exists($soarBinary)) {
-            throw new InvalidArgumentException("The file [$soarBinary] does not exist.");
-        }
-
-        if (!is_executable($soarBinary)) {
-            throw new InvalidArgumentException("The file [$soarBinary] is not executable.");
+        if (
+            !is_file($soarBinary)
+            // || !file_exists($soarBinary)
+            || !is_executable($soarBinary)
+        ) {
+            throw new InvalidArgumentException("The file [$soarBinary] does not exist or is not executable.");
         }
 
         $this->soarBinary = realpath($soarBinary);

tests/Concerns/ConcreteScoresTest.php

@@ -20,7 +20,6 @@
  * @see https://github.com/guanguans/soar-php
  */
 
-use Guanguans\SoarPHP\Exceptions\InvalidArgumentException;
 use Guanguans\SoarPHP\Soar;
 use Guanguans\SoarPHP\Support\OS;
 
@@ -111,13 +110,6 @@
         });
 });
 
-it('will throw InvalidArgumentException when sqls is boolean', function (): void {
-    Soar::create()->scores(true);
-})
-    ->group(__DIR__, __FILE__)
-    ->throws(InvalidArgumentException::class, \gettype(true))
-    ->skip();
-
 it('can get scores', function (): void {
     expect(Soar::create())
         ->scores('select * from users;')

tests/Concerns/HasSoarBinaryTest.php

@@ -46,6 +46,7 @@
     ->skip('This test is skipped. Because is not supported in github actions.');
 
 it('will throw InvalidArgumentException when set invalid binary', function (): void {
+    Soar::create()->setSoarBinary('/');
     Soar::create()->setSoarBinary('soar.path');
 })
     ->group(__DIR__, __FILE__)

tests/Concerns/WithRunableTest.php

@@ -18,18 +18,10 @@
 
 namespace Guanguans\SoarPHPTests\Concerns;
 
-use Guanguans\SoarPHP\Exceptions\InvalidArgumentException;
 use Guanguans\SoarPHP\Exceptions\ProcessFailedException;
 use Guanguans\SoarPHP\Soar;
 use Symfony\Component\Process\Process;
 
-it('will throw InvalidArgumentException when with-options is boolean', function (): void {
-    Soar::create()->run(true);
-})
-    ->group(__DIR__, __FILE__)
-    ->throws(InvalidArgumentException::class, \gettype(true))
-    ->skip();
-
 it('will throw ProcessFailedException when sqls is invalid sql', function (): void {
     Soar::create()->setOnlySyntaxCheck(true)->setQuery('invalid sql')->run();
 })