Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Min & Max aggregation methods #147

Open
dancelestini opened this issue Nov 1, 2024 · 4 comments
Open

Min & Max aggregation methods #147

dancelestini opened this issue Nov 1, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@dancelestini
Copy link

Hi Sopa team,

I'd like to request a feature that allows users to choose different aggregation methods for intensity measurements, rather than only calculating the average intensity. It would be very helpful to have options to compute minimum or maximum intensities in addition to the mean.

I suppose adding options in the function compute_table() would be the way to do that.

thanks for considering this :)

@quentinblampey
Copy link
Collaborator

Hi @dancelestini, indeed this is something that could be really interesting. I add this as a feature request.
I'm a little bit busy with a new version of sopa that I want to release in mid-november, so it will not come before that, but I definitely keep it in mind!

@quentinblampey quentinblampey added the enhancement New feature or request label Nov 4, 2024
@dancelestini
Copy link
Author

Dear @quentinblampey, Thanks for your quick answer, and very happy to learn that a new version is coming out soon! Looking forward to testing it. Thanks also for taking into consideration my feature request. I will wait for it :)

@quentinblampey
Copy link
Collaborator

Actually adding the min/max is pretty easy, I implemented it quickly and it will be available in sopa==2.0.0, I'll let you know when it's released!

@dancelestini
Copy link
Author

Ohh cool! This will really help us thanks a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants