From aa74dfa006a29781f68a7d76a6bf81face75aaa9 Mon Sep 17 00:00:00 2001 From: Thomas Dent Date: Fri, 23 Feb 2024 11:48:20 +0100 Subject: [PATCH 1/2] SNR optimizer option types Fix issue in non-default settings for some options that Max complained about --- bin/pycbc_optimize_snr | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bin/pycbc_optimize_snr b/bin/pycbc_optimize_snr index 5094a02dc62..bbdac2fa554 100755 --- a/bin/pycbc_optimize_snr +++ b/bin/pycbc_optimize_snr @@ -45,12 +45,12 @@ parser.add_argument('--psd-files', type=str, nargs='+', 'by PyCBC Live.') parser.add_argument('--approximant', required=True, help='Waveform approximant string.') -parser.add_argument('--snr-threshold', default=4.0, +parser.add_argument('--snr-threshold', type=float, default=4.0, help='If the SNR in ifo X is below this threshold do not ' 'consider it part of the coincidence. Not implemented') -parser.add_argument('--chirp-time-f-lower', default=20., +parser.add_argument('--chirp-time-f-lower', type=float, default=20., help='Starting frequency for chirp time window (Hz).') -parser.add_argument('--chirp-time-window', default=2., +parser.add_argument('--chirp-time-window', type=float, default=2., help='Chirp time window (s).') parser.add_argument('--gracedb-server', metavar='URL', help='URL of GraceDB server API for uploading events. ' From 81d32b16a3970009d1fb36558da2344a8614965a Mon Sep 17 00:00:00 2001 From: maxtrevor <65971534+maxtrevor@users.noreply.github.com> Date: Fri, 23 Feb 2024 12:00:07 -0500 Subject: [PATCH 2/2] Use standard verbosity argument --- bin/pycbc_optimize_snr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/pycbc_optimize_snr b/bin/pycbc_optimize_snr index bbdac2fa554..513f1d2fac5 100755 --- a/bin/pycbc_optimize_snr +++ b/bin/pycbc_optimize_snr @@ -27,9 +27,9 @@ from pycbc.live import snr_optimizer parser = argparse.ArgumentParser(description=__doc__) +pycbc.add_common_pycbc_options(parser) parser.add_argument('--version', action='version', version=version.git_verbose_msg) -parser.add_argument('--verbose', action='store_true') parser.add_argument('--params-file', required=True, help='Location of the attributes file created by PyCBC ' 'Live')