diff --git a/packages/yoga/src/Button/web/Button.jsx b/packages/yoga/src/Button/web/Button.jsx index 63b0b9b747..00ef1309fe 100644 --- a/packages/yoga/src/Button/web/Button.jsx +++ b/packages/yoga/src/Button/web/Button.jsx @@ -26,6 +26,7 @@ const Button = forwardRef( secondary = false, icon: Icon, isLoading = false, + 'aria-label': ariaLabel, ...props }, ref, @@ -49,6 +50,7 @@ const Button = forwardRef( small={small} secondary={secondary} isLoading={isLoading} + aria-label={ariaLabel} {...finalProps} > {Icon && } @@ -65,7 +67,6 @@ const Button = forwardRef( ); Button.propTypes = { - ariaLabel: string, children: node, disabled: bool, full: bool, @@ -77,6 +78,7 @@ Button.propTypes = { /** an Icon from yoga-icons package */ icon: oneOfType([node, func]), href: string, + 'aria-label': string, }; Button.displayName = 'Button'; diff --git a/packages/yoga/src/Heading/web/Heading.test.jsx b/packages/yoga/src/Heading/web/Heading.test.jsx index d0f828daf5..99db4faf9c 100644 --- a/packages/yoga/src/Heading/web/Heading.test.jsx +++ b/packages/yoga/src/Heading/web/Heading.test.jsx @@ -75,6 +75,24 @@ describe('', () => { expect(container).toMatchSnapshot(); }); + it('should have aria-label', () => { + const { getByLabelText } = render( + + + Gympass + + + + , + ); + + expect(getByLabelText('labelAriaText')).toBeTruthy(); + }); + it('should override the background color', () => { const { container } = render( diff --git a/packages/yoga/src/Heading/web/RightButton.jsx b/packages/yoga/src/Heading/web/RightButton.jsx index 213b6ef300..970053fd3a 100644 --- a/packages/yoga/src/Heading/web/RightButton.jsx +++ b/packages/yoga/src/Heading/web/RightButton.jsx @@ -58,8 +58,14 @@ const ButtonIcon = styled(Button)` }}; `; -const RightButton = ({ onClick, icon, ...props }) => ( - +const RightButton = ({ onClick, icon, 'aria-label': ariaLabel, ...props }) => ( + ( RightButton.propTypes = { onClick: PropTypes.func.isRequired, icon: PropTypes.elementType.isRequired, + 'aria-label': PropTypes.string, }; RightButton.displayName = 'Heading.RightButton'; diff --git a/packages/yoga/src/Menu/web/__snapshots__/Menu.test.jsx.snap b/packages/yoga/src/Menu/web/__snapshots__/Menu.test.jsx.snap index 290a16d2dd..cd26b14b8c 100644 --- a/packages/yoga/src/Menu/web/__snapshots__/Menu.test.jsx.snap +++ b/packages/yoga/src/Menu/web/__snapshots__/Menu.test.jsx.snap @@ -80,7 +80,6 @@ exports[` should match snapshot Menu with a onMouseHover props false 1`]