We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug In cursive-new-main/cursive-core/src/event.rs, the comment indicates that code should be panic when n == 0 while the code would not.
/// # Panics /// /// If `n == 0 || n > 12` pub fn from_f(n: u8) -> Key { match n { 0 => Key::F0, 1 => Key::F1, 2 => Key::F2, 3 => Key::F3, 4 => Key::F4, 5 => Key::F5, 6 => Key::F6, 7 => Key::F7, 8 => Key::F8, 9 => Key::F9, 10 => Key::F10, 11 => Key::F11, 12 => Key::F12, _ => panic!("unknown function key: F{n}"), } }
To Reproduce Key::from_f(0); That will not panic.
Expected behavior The code should be consistent with comment.
The text was updated successfully, but these errors were encountered:
Fix: deleted n == 0 match arm at line 448 (gyscos#804)
88926dc
Hi, and thanks for the report!
Indeed, it looks like the comment is inaccurate, possibly written before a F0 key was added.
F0
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Describe the bug
In cursive-new-main/cursive-core/src/event.rs, the comment indicates that code should be panic when n == 0 while the code would not.
To Reproduce
Key::from_f(0); That will not panic.
Expected behavior
The code should be consistent with comment.
The text was updated successfully, but these errors were encountered: