Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimension has no type exported #103

Open
prajnaprabhu3 opened this issue Sep 13, 2023 · 1 comment
Open

Dimension has no type exported #103

prajnaprabhu3 opened this issue Sep 13, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@prajnaprabhu3
Copy link

Describe the bug
dimensions which can be passed as prop to MenuProvider has no type import from kmenu. Its got a type Partial<Dimensions>

Expected behavior
dimensions has type Partial<Dimensions>. I don't see this type being exported. I'm not sure if there's any other way to use it, but exporting its type as MenuDimension similar to whats done for config as MenuConfig would be convenient.

import { Config } from './types';
import './styles/index.css';

export { CommandMenu } from './CommandMenu';
export { CommandWrapper } from './CommandWrapper';
export declare type MenuConfig = Partial<Config>;
export declare type MenuDimension = Partial<Dimensions>;

export { Command, MenuProps } from './types';
export { useShortcut } from './hooks/useShortcut';
export { useCommands } from './hooks/useCommands';
export { useKmenu } from './hooks/useKmenu';
export { MenuProvider } from './MenuProvider';

Additional context
Let me know if there's any other way this can be done.

@prajnaprabhu3 prajnaprabhu3 added the bug Something isn't working label Sep 13, 2023
@haaarshsingh
Copy link
Owner

@prajnaprabhu3 thanks for pointing this out, I'll get on it ASAP.

@haaarshsingh haaarshsingh self-assigned this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants