-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Animation between option items #106
Comments
Interesting why it overlaps the menu items when it's going down? I'll take a look. |
@heymartinadams do you prefer the select animation by yourself? |
@heymartinadams I'm working on an API rewrite for the colors right now. I think it's much easier for people to just customize the colors themselves in a CSS file as opposed to passing them into the menu. |
💯 agreed. That’s what we’re doing. |
Awesome! Has using the colors in CSS as opposed to passing them onto the menu fixed this issue? |
Modified style like this, for example. <style>{`
.category_header { height: 1rem; margin: 0.8rem 0.5rem 0.4rem; font-weight: 500; font-size: 0.75rem; }
.command {
color: ${!appDarkMode ? 'rgb(var(--colors-primary))' : 'rgb(var(--colors-primary-dark))'} !important;
}
.command, .selected { height: 2.4rem; margin: 0; border-radius: 0.25rem; }
`}</style> |
Yeah, you won't have to worry about doing weird stuff like this once the new update comes out. Some big things comin' your way. |
The animation is lovely. It just needs to be a bit faster, a bit snappier, especially for command menus that have a longer list of items. Is there any way we can set it ourselves?
Current animation:
CleanShot.2024-01-23.at.10.21.03.mp4
Example of snappier animation: (Linear)
CleanShot.2024-01-23.at.10.23.10.mp4
The text was updated successfully, but these errors were encountered: