Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eslint errors #77

Closed
wants to merge 2 commits into from
Closed

Fix eslint errors #77

wants to merge 2 commits into from

Conversation

ivaylonikolov7
Copy link
Contributor

@ivaylonikolov7 ivaylonikolov7 commented Apr 12, 2023 •
edited by imollov
Loading

  • bumps hardhat version
  • bumps typechain version
  • updates prettier, eslint and solhint settings
  • updates code with the new code formatter settings

partially resolves #75 and fully resolves #73

This PR is on hold until this problem is fixed - https://stackoverflow.com/questions/76016479/chainlinks-keeperregistry2-0-does-not-work-with-typechains-newest-version

@imollov imollov changed the title Bumbing hardhat boilerplate version Bump hardhat boilerplate version Apr 13, 2023
@ivaylonikolov7 ivaylonikolov7 force-pushed the feature/bump-hardhat-version branch 2 times, most recently from 24d3dbd to a3ecbfb Compare April 17, 2023 19:14
@ivaylonikolov7 ivaylonikolov7 changed the title Bump hardhat boilerplate version Bump hardhat boilerplate version and change code formatters settings Apr 17, 2023
@ivaylonikolov7 ivaylonikolov7 marked this pull request as ready for review April 17, 2023 19:36
@ivaylonikolov7 ivaylonikolov7 changed the title Bump hardhat boilerplate version and change code formatters settings Bump hardhat version and change code formatters settings Apr 17, 2023
@ivaylonikolov7 ivaylonikolov7 force-pushed the feature/bump-hardhat-version branch from a3ecbfb to 006b25f Compare April 17, 2023 20:23
@ivaylonikolov7 ivaylonikolov7 changed the title Bump hardhat version and change code formatters settings Bump hardhat version and change prettier and eslint settings Apr 18, 2023
@ivaylonikolov7 ivaylonikolov7 changed the title Bump hardhat version and change prettier and eslint settings Fix eslint errors Apr 18, 2023
@ivaylonikolov7 ivaylonikolov7 force-pushed the feature/bump-hardhat-version branch from 006b25f to a7cdb11 Compare April 18, 2023 12:41
@ivaylonikolov7 ivaylonikolov7 force-pushed the feature/bump-hardhat-version branch from a7cdb11 to 3934d9c Compare April 18, 2023 12:43
@ivaylonikolov7 ivaylonikolov7 force-pushed the feature/bump-hardhat-version branch from 3934d9c to b72b7dd Compare April 18, 2023 12:47
imollov
imollov reviewed Apr 18, 2023
View reviewed changes
test/utils/chainlink-automation.ts
@@ -244,29 +257,31 @@ export async function keeperRegistryPerformUpkeep(
[upkeepId],
registrySigners,
f + 1,
null,
undefined,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which rule causes this change?

test/utils/types.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move all types to their respective modules.

@imollov imollov closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imollov imollov imollov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade packages Fix eslint issues
2 participants
@ivaylonikolov7 @imollov