Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizing Weekly Label Check GHA #1555

Closed
3 tasks done
sydneywalcoff opened this issue Sep 16, 2024 · 3 comments · Fixed by #1601
Closed
3 tasks done

Optimizing Weekly Label Check GHA #1555

sydneywalcoff opened this issue Sep 16, 2024 · 3 comments · Fixed by #1601
Assignees
Labels
DevOps type of development task related to Process, Github Actions, and Deployment feature: GitHub/Project Board maintenance feature: team operations issues relating to team processes and operations issue level I: request Smallest type of issue; Typically can be completed by one person priority: medium role: development anything related to code size: 1pt can be done in 6 hours or less Status: Update Requested

Comments

@sydneywalcoff
Copy link
Member

sydneywalcoff commented Sep 16, 2024

Overview

While fixing a bug related to the Weekly Label Check, some opportunities for improvement have been identified.

  1. When the action fails, it just prints the error in the console and continues on and will 'pass' when it's finished. Rather than have it continue, the action should fail.

  2. The action doesn't currently inform anyone debugging how many issues have successfully been labeled after the action runs. Let's add a counter that prints how many issues were updated at the end of the script.

  3. Lines 91-93 are incorrect. Currently it shows the 'successful' text regardless of if the POST action to OctoKit was successful, and instead based on if there were any labels to be added to an issue. Update this logic to be dependent on the successful POST request to OctoKit.

Action Items

  • action should fail if there are errors
  • add affected Issues counter
  • update 'Success' logic on lines 91-93

Resources/Notes

Testing GHAs Locally
Weekly Label Check file

@sydneywalcoff sydneywalcoff added role: development anything related to code priority: medium size: 1pt can be done in 6 hours or less feature: GitHub/Project Board maintenance DevOps type of development task related to Process, Github Actions, and Deployment issue level I: request Smallest type of issue; Typically can be completed by one person feature: team operations issues relating to team processes and operations labels Sep 16, 2024
@sydneywalcoff sydneywalcoff added this to the Team Workflow milestone Sep 16, 2024
Copy link

Hey @whitneywind! Thanks for taking this issue.

To help keep everyone in the loop, please comment your Estimated Time to Completion (ETC) below!

Thanks again!

Copy link

github-actions bot commented Oct 3, 2024

Hey @whitneywind! Thanks again for taking this issue.

Time for an update! Please comment the following update:
**Progress:** What's the status of the project? What have you done and what still needs to be done?
**Estimated Time to Completion (ETC):** When do you estimate to be finished?
**Blockers:** Anything preventing you from finishing?

Thanks again!

@whitneywind
Copy link
Member

I have finished the second and third action items and will finish as soon as I clarify the details of the first one

This was referenced Oct 3, 2024
sydneywalcoff added a commit that referenced this issue Oct 8, 2024
@sydneywalcoff sydneywalcoff mentioned this issue Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps type of development task related to Process, Github Actions, and Deployment feature: GitHub/Project Board maintenance feature: team operations issues relating to team processes and operations issue level I: request Smallest type of issue; Typically can be completed by one person priority: medium role: development anything related to code size: 1pt can be done in 6 hours or less Status: Update Requested
Projects
Development

Successfully merging a pull request may close this issue.

2 participants