Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parsing): Ignore block and inline comments #46

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

heaths
Copy link
Contributor

@heaths heaths commented Sep 28, 2024

Fixes #43

CHANGELOG.md Outdated Show resolved Hide resolved
@hairyhenderson
Copy link
Owner

Sorry for the delay @heaths - overall this LGTM. Can you push with a new commit title that matches the conventional commit format? Something like fix(parsing): Ignore block and inline comments should do fine.

codeowners.go Outdated Show resolved Hide resolved
@heaths heaths changed the title Ignore block and inline comments fix(parsing): Ignore block and inline comments Oct 18, 2024
Copy link
Owner

@hairyhenderson hairyhenderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hairyhenderson hairyhenderson enabled auto-merge (squash) October 25, 2024 20:24
@hairyhenderson hairyhenderson merged commit 968c9ea into hairyhenderson:main Oct 25, 2024
5 checks passed
@heaths heaths deleted the issue43 branch October 26, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline comments are treated as owners
2 participants