Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow checking when no codeowners file is found #41

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pablochacin
Copy link

This will allow checking when no codeowners exists:

fsys := os.DirFS(cwd())

c, err  := FromFileWithFS(fsys, ".")

if errros.Is(err, ErrNoCodeownersFound) {
  // handle this case
}

Copy link
Owner

@hairyhenderson hairyhenderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great!

@hairyhenderson
Copy link
Owner

@pablochacin could I get you to amend your commit with a message like "feat(errors): Allow checking when no codeowners file is found"? Then this can merge.

@hairyhenderson hairyhenderson enabled auto-merge (squash) September 25, 2024 12:53
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
auto-merge was automatically disabled September 25, 2024 13:18

Head branch was pushed to by a user without write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants