Skip to content
This repository has been archived by the owner on Nov 3, 2019. It is now read-only.

Wondering if there should be an accessor to .Open? #9

Open
PureKrome opened this issue Feb 6, 2014 · 4 comments
Open

Wondering if there should be an accessor to .Open? #9

PureKrome opened this issue Feb 6, 2014 · 4 comments

Comments

@PureKrome
Copy link

This is something that i'm doing .. and right now .. there's no way I can. (Yes, i can fork and PR 👍 )

basically, my repo takes either a connection string or an IDbExecutor. 1st ctor is for my normal code. 2nd ctor is for my TDD.

(pseudo code @ gist)

The reason i'm using two ctors is because i might use the SqlConnection multiple times in a a method (eg. get users, get cats, get dogs) .. and i open/close for each one call as early as possible.

thoughts, @half-ogre ?

@PureKrome
Copy link
Author

Not sure if you'll get this auto-notification email, so i'm adding @half-ogre in this comment so you will (apologies for the dupe email, if you are getting notifications for this repo, now).

@half-ogre
Copy link
Owner

This is something that i'm doing .. and right now .. there's no way I can.

@PureKrome Can you put together a PR for what you have in mind? I'm all for making it easier to TDD but I'm distracted with other things tonight and can't take the time to noodle it.

Also, I'm happy to add you as a contributor as long as you're cool with the rules.

Not sure if you'll get this auto-notification email

(I'm getting notifications for this repo now; thanks!)

@PureKrome
Copy link
Author

I'll do a PR now - np at all :)

Nice set of rules! Great to know I already do 1, 2 and 4 -- but i'll sit on the side right now. I'm sure I'll feel different after i've been using this for a bit :)

I feel crap that i didn't know about this (repo) ages ago .. which suggests i've not been testing my dapper code :(

@half-ogre
Copy link
Owner

As I am sure you have already gathered from me neglecting issues on this repo, I am no longer (and haven't been for years) maintaining this library. I apologize it has taken me this long to properly respond to this to let you know, and to archive this repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants