Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin app with adding new projects #39

Open
3 of 4 tasks
davydovanton opened this issue Feb 6, 2018 · 13 comments
Open
3 of 4 tasks

Admin app with adding new projects #39

davydovanton opened this issue Feb 6, 2018 · 13 comments
Assignees

Comments

@davydovanton
Copy link
Member

davydovanton commented Feb 6, 2018

We can split this task to PRs (please, open one PR per task):

  • generate new admin application;
  • protect admin app by rack simple auth (password and user setup by ENV variables, default - `hanami/hanami') - Add protection for admin page using Rack simple auth #41
  • add page with all projects in db;
  • add form for adding a new project (with spawning sidekiq worker for export all commits)
@Bounga
Copy link
Contributor

Bounga commented Feb 8, 2018

Gonna work on adding a page listing all projects available in db tonight or at the latest this week-end if it's ok for you.

@davydovanton
Copy link
Member Author

yep, I'll be happy to see PR ;)

@GustavoCaso
Copy link
Member

If no one is working on the list item from the list I would like to work on it 🎉

@Bounga
Copy link
Contributor

Bounga commented Feb 11, 2018

@GustavoCaso Are you talking about the "add page with all projects in db;" item? If so it's already done.

I've started working on the last remaining task which is a form to add a project and spawning a background task to retrieve associated commits. If you're really interested in doing it I can stop my work and left it to you.

@GustavoCaso
Copy link
Member

Hi @Bounga please do not stop your work on that one. I would love to see how you solve it. 🎉

Thanks for the quick response.

@Bounga
Copy link
Contributor

Bounga commented Feb 11, 2018

@GustavoCaso You're welcome. Hope to deliver this feature tonight. Feel free to comment on it when it's available.

@davydovanton
Copy link
Member Author

@GustavoCaso if you want - I have other ideas for this project, we can start work on it 👍

@GustavoCaso
Copy link
Member

@davydovanton I would love to hear them ❤️💛💚. I have been meaning to try hanami and I think these is the best way

@Bounga
Copy link
Contributor

Bounga commented Feb 11, 2018

@GustavoCaso I also think it's one a the best way to start with Hanami. And it's useful to other people. That's why I'm contributing. If you want to peer on some feature I'd really like to.

@davydovanton I'd love to hear about it too. I saw an idea about creating a variable for the organization and I think it's a freaking good idea. I think I'll have some free time in the next weeks to dedicate to this project. If I can help, I will.

@Bounga
Copy link
Contributor

Bounga commented Feb 21, 2018

I've started working on the remaining task but I don't have a lot of free time these days. It's going to be easier for me to finish this next week. Here's what I've done so far https://github.com/Bounga/contributors/tree/add-new-project-from-admin

@davydovanton
Copy link
Member Author

@Bounga thanks for share your status ❤️
don't worry about it :)

@nagano564
Copy link

nagano564 commented Mar 20, 2018

is someone still working on this?? @davydovanton

@Bounga
Copy link
Contributor

Bounga commented Mar 20, 2018

@nagano564 Yes I’m still working on it. I do have something working actually that you can see in my branch linked above. I still want to add some missing tests and refactor duplicated code. I think it’ll be done by this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants