From 7495f9d267b1af79a4cb20281fed9b8b759d6d0f Mon Sep 17 00:00:00 2001
From: Francesco Torchia <francesco.torchia@suse.com>
Date: Tue, 24 Sep 2024 11:12:00 +0200
Subject: [PATCH 1/2] Fix Node list in VMs Migrate dialog

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
---
 pkg/harvester/dialog/HarvesterMigrationDialog.vue | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/pkg/harvester/dialog/HarvesterMigrationDialog.vue b/pkg/harvester/dialog/HarvesterMigrationDialog.vue
index 9fe8811ca6e..0a16793bc88 100644
--- a/pkg/harvester/dialog/HarvesterMigrationDialog.vue
+++ b/pkg/harvester/dialog/HarvesterMigrationDialog.vue
@@ -74,7 +74,8 @@ export default {
       return nodes.filter((n) => {
         const isNotSelfNode = !!this.availableNodes.includes(n.id);
         const isNotWitnessNode = n.isEtcd !== 'true'; // do not allow to migrate to self node and witness node
-        const matchingCpuManagerConfig = n.isCPUManagerEnabled; // If cpu-pinning is enabled, filter-out non-enabled CPU manager nodes.
+        const isCpuPinning = this.actionResource?.spec?.template?.spec?.domain?.cpu?.dedicatedCpuPlacement;
+        const matchingCpuManagerConfig = !isCpuPinning || n.isCPUManagerEnabled; // If cpu-pinning is enabled, filter-out non-enabled CPU manager nodes.
 
         return isNotSelfNode && isNotWitnessNode && matchingCpuManagerConfig;
       }).map((n) => {

From 1d16e2fe2e8119ead7c122ce8e112bfbbdcce179 Mon Sep 17 00:00:00 2001
From: "andy.lee" <andy.lee@suse.com>
Date: Wed, 25 Sep 2024 11:19:41 +0800
Subject: [PATCH 2/2] add warning banner for cpu pinning VM in migration dialog

Signed-off-by: andy.lee <andy.lee@suse.com>
---
 pkg/harvester/dialog/HarvesterMigrationDialog.vue  | 8 ++++++--
 pkg/harvester/l10n/en-us.yaml                      | 1 +
 pkg/harvester/models/kubevirt.io.virtualmachine.js | 4 ++++
 3 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/pkg/harvester/dialog/HarvesterMigrationDialog.vue b/pkg/harvester/dialog/HarvesterMigrationDialog.vue
index 0a16793bc88..e141ce0ba92 100644
--- a/pkg/harvester/dialog/HarvesterMigrationDialog.vue
+++ b/pkg/harvester/dialog/HarvesterMigrationDialog.vue
@@ -68,13 +68,17 @@ export default {
       return resource;
     },
 
+    cpuPinningAlertMessage() {
+      return this.t('harvester.virtualMachine.cpuPinning.migrationMessage');
+    },
+
     nodeNameList() {
       const nodes = this.$store.getters['harvester/all'](NODE);
 
       return nodes.filter((n) => {
         const isNotSelfNode = !!this.availableNodes.includes(n.id);
         const isNotWitnessNode = n.isEtcd !== 'true'; // do not allow to migrate to self node and witness node
-        const isCpuPinning = this.actionResource?.spec?.template?.spec?.domain?.cpu?.dedicatedCpuPlacement;
+        const isCpuPinning = this.actionResource?.isCpuPinning;
         const matchingCpuManagerConfig = !isCpuPinning || n.isCPUManagerEnabled; // If cpu-pinning is enabled, filter-out non-enabled CPU manager nodes.
 
         return isNotSelfNode && isNotWitnessNode && matchingCpuManagerConfig;
@@ -144,6 +148,7 @@ export default {
     </template>
 
     <template #body>
+      <Banner v-if="actionResource?.isCpuPinning" color="warning" :label="cpuPinningAlertMessage" />
       <LabeledSelect
         v-model="nodeName"
         :label="t('harvester.modal.migration.fields.nodeName.label')"
@@ -164,7 +169,6 @@ export default {
           @click="apply"
         />
       </div>
-
       <Banner v-for="(err, i) in errors" :key="i" color="error" :label="err" />
     </div>
   </Card>
diff --git a/pkg/harvester/l10n/en-us.yaml b/pkg/harvester/l10n/en-us.yaml
index 56638f4c10e..9f31a04e857 100644
--- a/pkg/harvester/l10n/en-us.yaml
+++ b/pkg/harvester/l10n/en-us.yaml
@@ -521,6 +521,7 @@ harvester:
       label: Enable CPU Pinning
       tooltip: Enable CPU Pinning brings better performance and reduce latency for the virtual machine 
       restartVMMessage: Changing the CPU Pinning setting requires a virtual machine reboot for the change to take effect
+      migrationMessage: This virtual machine can only be migrated to a target node that has CPU Manager enabled, as CPU Pinning is configured.
     restartNow: |-
       {restart, select,
         true {Restart}
diff --git a/pkg/harvester/models/kubevirt.io.virtualmachine.js b/pkg/harvester/models/kubevirt.io.virtualmachine.js
index c1cc091c12f..6ad7ee9861a 100644
--- a/pkg/harvester/models/kubevirt.io.virtualmachine.js
+++ b/pkg/harvester/models/kubevirt.io.virtualmachine.js
@@ -460,6 +460,10 @@ export default class VirtVm extends HarvesterResource {
     return null;
   }
 
+  get isCpuPinning() {
+    return this.spec?.template?.spec?.domain?.cpu?.dedicatedCpuPlacement === true;
+  }
+
   get isVMExpectedRunning() {
     if (!this?.spec) {
       return false;