Support USB Passthrough #1069

torchiaf · 2024-07-16T10:45:47Z

Summary

PR Checklist

Is this a multi-tenancy feature/bug?
- Yes, the relevant RBAC changes are at:
Do we need to backport changes to the old Rancher UI, such as RKE1?
- Yes, the relevant PR is at:
Are backend engineers aware of UI changes?
- Yes, the backend owner is:

Related Issue harvester/harvester#5763

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Disable/Enable PCI addon -> USB page visibility
Enable/Disable USB device
Assign PCI/USB devices to VMs

Areas which could experience regressions

PCI devices page

Screenshot/Video

USB devices

Groups

VM edit mode

Yu-Jack · 2024-09-09T09:27:59Z

Few questions, not sure whether it's Harvester version issue. In my local Harvester, I just enabled pcidevices-controller Add-on. Did I miss something?

I opened the USB Device Page with embedded Rancher and enabled one of them. Other USB devices show weird status.

I tried to create a virtual machine. After I clicked the Create button in virtual machine image page. It showed this error message. It seems some variables are undefined in some cases.

torchiaf · 2024-09-09T09:58:04Z

I opened the USB Device Page with embedded Rancher and enabled one of them. Other USB devices show weird status.

I'm trying to replicate it.

I tried to create a virtual machine. After I clicked the Create button in virtual machine image page. It showed this error message. It seems some variables are undefined in some cases.

This is a UI bug, b84a4f5 should fix it.

torchiaf · 2024-09-09T10:41:22Z

I opened the USB Device Page with embedded Rancher and enabled one of them. Other USB devices show weird status.

It's fixed in 02fe957

Yu-Jack · 2024-09-10T04:18:18Z

Found a issue. After I enabled the USB Device, the Claimed By showed nothing.

But, the usbdevicecalim contains it.

torchiaf · 2024-09-10T08:54:12Z

Found a issue. After I enabled the USB Device, the Claimed By showed nothing.

Fixed, thanks!

a110605 · 2024-09-11T06:02:23Z

The enable link is jump to error when pci-addon is disabled.
Missing USB_DEVICE_CONTROLLER in ADD_ONS.

a110605 · 2024-09-11T06:32:20Z

Not sure why but sort the columns cause enable/disable passthrough button switch.

button_switch.webm

a110605 · 2024-09-11T06:32:52Z

Enable group dialog is empty.

a110605 · 2024-09-11T06:42:16Z

Why I can't disable usb device ? Same for disable group button
cc @Yu-Jack

Yu-Jack · 2024-09-11T06:58:33Z

Why I can't disable usb device ? Same for disable group button cc @Yu-Jack

@a110605 @torchiaf It seems the Add-on is restarted. Because I patched the daemonset image directly, so it will be reset if Add-on is restarted. Please check the daemonset(harvester-system/harvester-pcidevices-controller) image is jk82421/pcidevices:v0.4.0.10 or not before testing.

a110605 · 2024-09-11T07:19:10Z

It's nice to block user create VM with un-existed or un-enabled device name if directly edit YAML. cc @Yu-Jack

pkg/harvester/list/devices.harvesterhci.io.usbdevice.vue

pkg/harvester/edit/kubevirt.io.virtualmachine/VirtualMachineUSBDevices/index.vue

mergify · 2024-09-12T08:44:50Z

This pull request is now in conflict. Could you fix it @torchiaf? 🙏

pkg/harvester/models/devices.harvesterhci.io.usbdevice.js

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

…aim type Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

- Add columns and filters - Filter other vm devices in pci and usb devices pages when selecting devices Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

…BDevices/index.vue Co-authored-by: Jack Yu <jack.yu@suse.com>

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

a110605

LGTM

torchiaf · 2024-09-24T08:08:23Z

@mergify backport release-harvester-v1.4

mergify · 2024-09-24T08:08:30Z

backport release-harvester-v1.4

✅ Backports have been created

#1167 Support USB Passthrough (backport #1069) has been created for branch release-harvester-v1.4

…v1.4/pr-1069 Support USB Passthrough (backport #1069)

github-actions bot assigned torchiaf Jul 16, 2024

torchiaf changed the title ~~5763 usb~~ Support USB Passthrough Jul 16, 2024

a110605 added Draft PR The PR still no ready New Feature New feature for up coming release labels Aug 26, 2024

torchiaf force-pushed the 5763-usb branch 2 times, most recently from 9141d87 to d7ed6b0 Compare September 8, 2024 16:13

torchiaf marked this pull request as ready for review September 8, 2024 16:13

torchiaf requested a review from a110605 September 8, 2024 16:35

Yu-Jack mentioned this pull request Sep 9, 2024

fix: userName should be in spec instead of status harvester/pcidevices#89

Merged

torchiaf removed the Draft PR The PR still no ready label Sep 9, 2024

torchiaf force-pushed the 5763-usb branch from d7ed6b0 to b6c91c5 Compare September 9, 2024 08:51

a110605 requested a review from Yu-Jack September 9, 2024 09:12

torchiaf force-pushed the 5763-usb branch 2 times, most recently from 7c0de51 to 02fe957 Compare September 9, 2024 10:40

a110605 reviewed Sep 11, 2024

View reviewed changes

pkg/harvester/list/devices.harvesterhci.io.usbdevice.vue Show resolved Hide resolved

This was referenced Sep 11, 2024

feat: add validation to check hostDevices[].name and .deviceName harvester/pcidevices#90

Closed

[ENHANCEMENT] Name and DeviceName in HostDevices should match harvester/harvester#6542

Open

Yu-Jack reviewed Sep 12, 2024

View reviewed changes

a110605 reviewed Sep 23, 2024

View reviewed changes

pkg/harvester/models/devices.harvesterhci.io.usbdevice.js Outdated Show resolved Hide resolved

torchiaf requested a review from a110605 September 23, 2024 10:33

torchiaf and others added 20 commits September 23, 2024 12:54

Remove useless var from sriovGpu devices

26512c7

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Fix VGPUDeviceList name

0b44117

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Add USB devices page skeleton

09a1f21

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Add Comptibility Matrix to USB devices tab

c9b37a0

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Refactoring USB Device list component; add USBDevice model; add usbcl…

a042969

…aim type Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Remove usb controller

e2ec04e

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Split passthrough to usb and pci components

93fc63b

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Enable USB devices by pci controller

b4a60cd

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Update USB devices

79c5d8b

- Add columns and filters - Filter other vm devices in pci and usb devices pages when selecting devices Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Fix lint errors

117018b

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Remove USB tab from navLink based on schema

4162f3a

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Add missing empty devices check

e6930f7

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Fix usb passthrough claim get condition

b2572d7

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Fixed ClaimedBy column

dd79472

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Update pkg/harvester/edit/kubevirt.io.virtualmachine/VirtualMachineUS…

0a70643

…BDevices/index.vue Co-authored-by: Jack Yu <jack.yu@suse.com>

Fix PCI addon link in USB page warning banner

ebd74d0

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Refactoring devices models

c87cc05

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Add enable warning message

b8c81f0

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Clean up code for readability

8a8ec1f

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

Fix buttons switch and clean up unused headers

58ce1b1

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>

torchiaf force-pushed the 5763-usb branch from c718cb1 to 58ce1b1 Compare September 23, 2024 10:55

a110605 approved these changes Sep 23, 2024

View reviewed changes

Yu-Jack mentioned this pull request Sep 24, 2024

[FEATURE] USB passthrough support harvester/harvester#1710

Open

torchiaf merged commit a2a67e7 into harvester:master Sep 24, 2024
7 checks passed

mergify bot mentioned this pull request Sep 24, 2024

Support USB Passthrough (backport #1069) #1167

Merged

3 tasks

torchiaf added a commit that referenced this pull request Sep 24, 2024

Merge pull request #1167 from harvester/mergify/bp/release-harvester-…

f5f76a1

…v1.4/pr-1069 Support USB Passthrough (backport #1069)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support USB Passthrough #1069

Support USB Passthrough #1069

torchiaf commented Jul 16, 2024 •

edited

Loading

Yu-Jack commented Sep 9, 2024 •

edited

Loading

torchiaf commented Sep 9, 2024 •

edited

Loading

torchiaf commented Sep 9, 2024

Yu-Jack commented Sep 10, 2024 •

edited

Loading

torchiaf commented Sep 10, 2024

a110605 commented Sep 11, 2024 •

edited

Loading

a110605 commented Sep 11, 2024 •

edited

Loading

a110605 commented Sep 11, 2024

a110605 commented Sep 11, 2024

Yu-Jack commented Sep 11, 2024 •

edited

Loading

a110605 commented Sep 11, 2024 •

edited

Loading

mergify bot commented Sep 12, 2024

a110605 left a comment

torchiaf commented Sep 24, 2024

mergify bot commented Sep 24, 2024

Support USB Passthrough #1069

Support USB Passthrough #1069

Conversation

torchiaf commented Jul 16, 2024 • edited Loading

Summary

PR Checklist

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Yu-Jack commented Sep 9, 2024 • edited Loading

torchiaf commented Sep 9, 2024 • edited Loading

torchiaf commented Sep 9, 2024

Yu-Jack commented Sep 10, 2024 • edited Loading

torchiaf commented Sep 10, 2024

a110605 commented Sep 11, 2024 • edited Loading

a110605 commented Sep 11, 2024 • edited Loading

a110605 commented Sep 11, 2024

a110605 commented Sep 11, 2024

Yu-Jack commented Sep 11, 2024 • edited Loading

a110605 commented Sep 11, 2024 • edited Loading

mergify bot commented Sep 12, 2024

a110605 left a comment

Choose a reason for hiding this comment

torchiaf commented Sep 24, 2024

mergify bot commented Sep 24, 2024

✅ Backports have been created

torchiaf commented Jul 16, 2024 •

edited

Loading

Yu-Jack commented Sep 9, 2024 •

edited

Loading

torchiaf commented Sep 9, 2024 •

edited

Loading

Yu-Jack commented Sep 10, 2024 •

edited

Loading

a110605 commented Sep 11, 2024 •

edited

Loading

a110605 commented Sep 11, 2024 •

edited

Loading

Yu-Jack commented Sep 11, 2024 •

edited

Loading

a110605 commented Sep 11, 2024 •

edited

Loading