Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move reserved memory out from Read More in VM and VM template detail pages #1117

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Move reserved memory out from Read More in VM and VM template detail pages #1117

merged 1 commit into from
Aug 29, 2024
+14 −14

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Aug 28, 2024 •
edited
Loading

Summary

Move reserved memory out from Read More in VM and VM template pages

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Related Issue #
harvester/harvester#5768 (comment)

Occurred changes and/or fixed issues

Screenshot/Video

VM detail and edit page
Screenshot 2024-08-28 at 1 55 28 PM

VM template detail and edit page
Screenshot 2024-08-28 at 1 56 51 PM

@a110605
Move reserved memory out from Read More in VM and VM template detail …
6432f52 
…pages

Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605 a110605 self-assigned this Aug 28, 2024
@a110605 a110605 mentioned this pull request Aug 28, 2024
Closed
@a110605
Copy link
Collaborator Author

a110605 commented Aug 28, 2024

Maybe we can consider adding placeholder for reserved memory inputbox.

image

@a110605 a110605 added the Enhancement minor or greater UI enhancement label Aug 28, 2024
@w13915984028
Copy link
Member

w13915984028 commented Aug 28, 2024 •
edited
Loading

@a110605 The PR looks good, thanks.

For the Reserved Memory #1117 (comment):

Before v1.4.0, Harvester will reserve 100Mi by default, it is OK to show 100Mi on the UI.

In v1.4.0, I am working a new PR harvester/harvester#6177 and harvester/harvester#6438, which has a new setting called AdditionalGuestMemoryOverheadRatio (taken from upstream kubevirt).

With this setting, we can keep to leave Reserved Memory blank. When user doesn't fill Reserved Memory on UI, the backend will decide a dynamic value based on a couple of conditions. thanks.

votdev
votdev approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@votdev votdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

w13915984028
w13915984028 approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@w13915984028 w13915984028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@bk201 bk201 merged commit 426f953 into harvester:master Aug 29, 2024
9 checks passed
@a110605
Copy link
Collaborator Author

a110605 commented Aug 30, 2024

@mergify backport release-harvester-v1.4

@mergify Mergify
Copy link

mergify bot commented Aug 30, 2024 •
edited
Loading

backport release-harvester-v1.4

✅ Backports have been created

@mergify mergify bot mentioned this pull request Aug 30, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w13915984028 w13915984028 w13915984028 approved these changes

@votdev votdev votdev approved these changes

@bk201 bk201 bk201 approved these changes

@torchiaf torchiaf Awaiting requested review from torchiaf

Assignees

@a110605 a110605

Labels
Enhancement minor or greater UI enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a110605 @w13915984028 @bk201 @votdev