Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check harvester resource quota schema to prevent unknown schema error #1135

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Sep 9, 2024

Summary

To prevent unknown resource quota schema error. Add check harvester resource quota schema.

image

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Issue #
[GUI] [FEATURE] Allow users to set count/size limit on snapshots

Screenshot/Video

Test on

@a110605 a110605 self-assigned this Sep 9, 2024
@a110605 a110605 changed the title check harvester resource quota schema to prevent unexpected error Check harvester resource quota schema to prevent unknown schema error Sep 9, 2024
@@ -253,7 +252,7 @@ export function init($plugin, store) {

// singleVirtualCluster
if (isSingleVirtualCluster) {
headers(NAMESPACE, [STATE, NAME_UNLINKED, NS_SNAPSHOT_QUOTA, AGE]);
headers(NAMESPACE, [STATE, NAME_UNLINKED, AGE]);
Copy link
Collaborator Author

@a110605 a110605 Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditionally add NS_SNAPSHOT_QUOTA header in shell/components/ExplorerProjectsNamespaces.vue and shell/list/namespace.vue

@a110605 a110605 added the Bug Fix Something isn't working label Sep 9, 2024
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 merged commit 1aaeaef into harvester:master Sep 9, 2024
8 checks passed
@a110605
Copy link
Collaborator Author

a110605 commented Sep 10, 2024

@mergify backport release-harvester-v1.4

Copy link

mergify bot commented Sep 10, 2024

backport release-harvester-v1.4

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants