Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add provisioned vGpus in VM's devices list. #1154

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Add provisioned vGpus in VM's devices list. #1154

merged 1 commit into from
Sep 25, 2024

Conversation

torchiaf
Copy link
Collaborator

@torchiaf torchiaf commented Sep 17, 2024 •
edited
Loading

Summary

It adds the vGpu devices tracked in VM's annotation to the VM's vGpu list.
Those vGpus are provisioned by Harvester when creating new clusters from Rancher.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Related Harvester Issue harvester/harvester#6638
Blocks rancher#11399

Occurred changes and/or fixed issues

Technical notes summary

  • We need to define how to remove the provisioned vGpus. cc @ibrokethecloud

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

@torchiaf torchiaf requested review from a110605 and ibrokethecloud and removed request for ibrokethecloud September 17, 2024 22:12
@torchiaf torchiaf changed the title Update selected vGpus devices adding the provisioned devices Add provisioned vGpus in VM's devices list. Sep 17, 2024
@torchiaf torchiaf mentioned this pull request Sep 17, 2024
Open
7 tasks
a110605
a110605 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@a110605 a110605 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change is good.

@a110605 a110605 added the Enhancement minor or greater UI enhancement label Sep 19, 2024
@mergify Mergify
Copy link

mergify bot commented Sep 24, 2024

This pull request is now in conflict. Could you fix it @torchiaf? 🙏

@torchiaf
Update selected vGpus devices adding the provisioned devices
ca6ff46 
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
@torchiaf torchiaf force-pushed the fix-harvester-gpu-provisioned-assignemend branch from 8c03fee to ca6ff46 Compare September 24, 2024 09:23
a110605
a110605 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@a110605 a110605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@torchiaf torchiaf merged commit c2f1a47 into harvester:master Sep 25, 2024
8 checks passed
@torchiaf
Copy link
Collaborator Author

@mergify backport release-harvester-v1.4 release-harvester-v1.3

@mergify Mergify
Copy link

mergify bot commented Sep 25, 2024 •
edited
Loading

backport release-harvester-v1.4 release-harvester-v1.3

✅ Backports have been created

This was referenced Sep 25, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a110605 a110605 a110605 approved these changes

Assignees

@torchiaf torchiaf

Labels
Enhancement minor or greater UI enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@torchiaf @a110605