Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encrypt image and decrypt image actions #1165

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Sep 24, 2024

Summary

From previous PR comment : #1151 (review)

Modify

  • show image_ns/image_displayName as encrypt / decryt dropdown options
  • add Encrypt Image / decrypt Image actions
  • show Source Image in image detail and fix source Image in edit view page

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Related Issue #
harvester/harvester#6493

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Add Encrypt Image or Decrypt Image actions
Screenshot 2024-09-24 at 12 38 01 PM

Show source Image in detail page
Screenshot 2024-09-24 at 12 38 06 PM

image

Show image namespace + displayName as options

image

@a110605 a110605 self-assigned this Sep 24, 2024
@a110605 a110605 added the Enhancement minor or greater UI enhancement label Sep 24, 2024
Copy link
Collaborator

@Yu-Jack Yu-Jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Signed-off-by: andy.lee <andy.lee@suse.com>
Copy link
Collaborator

@Yu-Jack Yu-Jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for quick fixing.

@a110605 a110605 merged commit 445aab7 into harvester:master Sep 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement minor or greater UI enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants