Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check-plugins CI job #1170

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Fix check-plugins CI job #1170

merged 2 commits into from
Sep 25, 2024

Conversation

a110605
Copy link
Collaborator

@a110605 a110605 commented Sep 25, 2024

Summary

Fix https://github.com/harvester/dashboard/actions/runs/11025700963/job/30621227120?pr=1168

I tried using node 20 in creator package like https://github.com/rancher/dashboard/pull/11808/files did.

But @nuxt/babel-present-app is not compatible to node 20.....

Screenshot 2024-09-25 at 12 08 51 PM

Pin the @types/node to v16 instead.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?
    • Yes, the backend owner is:

Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605 a110605 changed the title fix administrator typo Fix administrator typo Sep 25, 2024
Signed-off-by: andy.lee <andy.lee@suse.com>
@a110605 a110605 changed the title Fix administrator typo Fix check-plugins CI job Sep 25, 2024
@a110605 a110605 mentioned this pull request Sep 25, 2024
3 tasks
@a110605 a110605 added the CI/CD label Sep 25, 2024
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@a110605 a110605 merged commit 66068a6 into harvester:master Sep 25, 2024
10 checks passed
@mergify mergify bot mentioned this pull request Sep 25, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants