Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Final edits to the UI strings #1176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asettle
Copy link

@asettle asettle commented Sep 26, 2024

  1. Currently unable to chagne the message "VirtualMachine generation is 2..."
  2. Discrepency between "cluster flow/flows" etc is out of my control for the UI string changes.

Closes rancher#6407

1. Currently unable to chagne the message "VirtualMachine generation is 2..."
2. Discrepency between "cluster flow/flows" etc is out of my control for the UI string changes.

Signed-off-by: Alexandra Settle <asettle@suse.com>
@a110605
Copy link
Collaborator

a110605 commented Sep 26, 2024

Discrepency between "cluster flow/flows" etc is out of my control for the UI string changes.

You can remove 99 in harvesterhci.io.logging.clusterflow.vue to keep label/For getter use default count = 1 to get typeDisplay (list page title)

 return this.$store.getters['type-map/labelFor'](schema);

Same for harvesterhci.io.logging.clusteroutput.vue / flow.vue / output.vue

@a110605
Copy link
Collaborator

a110605 commented Sep 26, 2024

Currently unable to chagne the message "VirtualMachine generation is 2..."

Hi @Yu-Jack or @FrankYang0529 ,

Could you kindly help separate the wording "VirtualMachine" to "Virtual Machine" in harvester/vendor/sigs.k8s.io/cli-utils/pkg/kstatus/status/generic.go ?

Screenshot 2024-09-26 at 2 22 47 PM

@FrankYang0529
Copy link
Member

Currently unable to chagne the message "VirtualMachine generation is 2..."

Hi @Yu-Jack or @FrankYang0529 ,

Could you kindly help separate the wording "VirtualMachine" to "Virtual Machine" in harvester/vendor/sigs.k8s.io/cli-utils/pkg/kstatus/status/generic.go ?

Screenshot 2024-09-26 at 2 22 47 PM

Hi @a110605, we may not be able to do that. harvester/vendor/sigs.k8s.io/cli-utils/pkg/kstatus/status/generic.go is upstream code. Also, VirtualMachine is defined in upstream.

@Yu-Jack
Copy link
Collaborator

Yu-Jack commented Sep 26, 2024

BTW, it's a Kind, so it's slightly different meaning between VirtualMachine and Virtual Machine.

@Yu-Jack
Copy link
Collaborator

Yu-Jack commented Sep 26, 2024

“VirtualMachine” in “VirtualMachine generation is 2...” means that this resource is in k8s. “Virtual Machine” means that we usually used it to describe about VM. So, I suggest not to revise this word.

@a110605 a110605 added the Documentation Improvements or additions to documentation label Sep 26, 2024
@asettle
Copy link
Author

asettle commented Sep 26, 2024

“VirtualMachine” in “VirtualMachine generation is 2...” means that this resource is in k8s. “Virtual Machine” means that we usually used it to describe about VM. So, I suggest not to revise this word.

Hmm I understand. That being said, because it's the same text, it looks like a spelling mistake. Can we apply some mark-up to 'VirtualMachine' to ensure it's clear?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants