Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VM schedules pages (backport #1103) #1179

Open
wants to merge 7 commits into
base: release-harvester-v1.4
Choose a base branch
from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Sep 27, 2024

Summary

  • add VM schedule list / edit / details pages
  • add VM schedule column in vmbackup / vmsnapshot list pages
  • add Create VM Scheduleaction for VM operation menu
  • show volume backup error message and readyToUse in backup/snapshot detail volume tab <- discussion conclusion with the team
  • upgrade cron-validator and cronstrue to the latest version

Note. this UI PR needs wait for backend PR harvester/harvester#6149 merge first.

PR Checklist

  • Is this a multi-tenancy feature/bug?
    • Yes, the relevant RBAC changes are at:
  • Do we need to backport changes to the old Rancher UI, such as RKE1?
    • Yes, the relevant PR is at:
  • Are backend engineers aware of UI changes?

Related Issue #
harvester/harvester#6058

Technical notes summary

run yarn install before run up the harvester dashboard

Screenshot/Video

  1. Create VM Schedule
create_scheduling.mov
  1. Edit VM Schedule
update_schedule.mov
  1. See VM Schedule detail
schedule_detail.mov
  1. show error banner if not set backup target
show_error_backup_target.mov
  1. When create back up failed and reach Max Failure threshold, the schedule job would auto suspended.

auto_stop_schedule

  1. Show volume backup error message and readyToUse in backup/snapshot detail volume tab
volume_backup_error.mov

This is an automatic backport of pull request #1103 done by [Mergify](https://mergify.com).

- add VM schedule list/edit/details pages
- add VM schedule column in vmbackup/vmsnapshot list pages
- add action menu for VM
- show volume backup error message in backup/snapshot detail volume tab

Signed-off-by: andy.lee <andy.lee@suse.com>
(cherry picked from commit 8ce0f8e)
Signed-off-by: andy.lee <andy.lee@suse.com>
(cherry picked from commit 6f16516)
Signed-off-by: andy.lee <andy.lee@suse.com>
(cherry picked from commit 5a9a662)
Signed-off-by: andy.lee <andy.lee@suse.com>
(cherry picked from commit c02f2c2)
Signed-off-by: andy.lee <andy.lee@suse.com>
(cherry picked from commit eabd943)

# Conflicts:
#	pkg/harvester/config/labels-annotations.js
@mergify mergify bot added Backport to v1.4 Backport PR target v1.4 Conflicts labels Sep 27, 2024
Copy link
Author

mergify bot commented Sep 27, 2024

Cherry-pick of eabd943 has failed:

On branch mergify/bp/release-harvester-v1.4/pr-1103
Your branch is ahead of 'origin/release-harvester-v1.4' by 5 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit eabd94355.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   pkg/harvester/components/FilterVMSchedule.vue
	modified:   pkg/harvester/detail/harvesterhci.io.schedulevmbackup/BackupList.vue
	modified:   pkg/harvester/detail/harvesterhci.io.schedulevmbackup/SnapshotList.vue
	deleted:    pkg/harvester/dialog/HarvesterScheduleModal.vue
	modified:   pkg/harvester/edit/harvesterhci.io.virtualmachinebackup.vue
	modified:   pkg/harvester/edit/harvesterhci.io.vmsnapshot.vue
	modified:   pkg/harvester/models/harvesterhci.io.virtualmachinebackup.js

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   pkg/harvester/config/labels-annotations.js

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Copy link
Collaborator

@torchiaf torchiaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport to v1.4 Backport PR target v1.4 Conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants