Add disks labels to provisioned disks #951
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torchiaf
force-pushed
the
2770-disks-labels
branch
from
c3ace69
to
d196e22
Compare
torchiaf
force-pushed
the
2770-disks-labels
branch
from
d196e22
to
5f74181
Compare
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
Signed-off-by: Francesco Torchia <francesco.torchia@suse.com>
torchiaf
force-pushed
the
2770-disks-labels
branch
from
5f74181
to
d4fa8c8
Compare
|
I've finalized this PR. Could you please tests it with witness node @a110605 ? |
|
Current host disk tab support add tag when provisioning new disk, do we still need this PR? 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR Checklist
Fixes harvester/harvester#2770
Occurred changes and/or fixed issues
Technical notes summary
It adds disk tags to provisioned disks when saving.
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Details page
Config page
Edit page