doc: Add maintenance mode improvements #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for harvester-preview ready!
|
votdev
force-pushed
the
issue_5069_improve_maintenance_mode
branch
from
e543adf
to
07162d1
Compare
votdev
force-pushed
the
issue_5069_improve_maintenance_mode
branch
from
07162d1
to
747db8d
Compare
votdev
force-pushed
the
issue_5069_improve_maintenance_mode
branch
2 times, most recently
from
01f088b
to
2e63c7d
Compare
w13915984028
reviewed
Jun 5, 2024
|
I am currently writing a HEP for that issue to clarify how the label and everything is named. |
votdev
force-pushed
the
issue_5069_improve_maintenance_mode
branch
from
2e63c7d
to
bcb9f77
Compare
votdev
added a commit
to votdev/harvester
that referenced
this pull request
Jul 3, 2024
Introduce the label `harvesterhci.io/maintain-mode-strategy` which can be added to a `VirtualMachine` resource to specify the behaviour of the VM in case of a node maintenance event. The following modes are supported: - `Migrate` (default): The VM will be live-migrated to another node in the cluster. This is the behavior of the maintenance feature as it is at the moment and will be default with this enhancement. - `ShutdownAndRestartAfterEnable`: Shut down and restart the VM after maintenance mode is enabled. The VM will be scheduled on a different node. - `ShutdownAndRestartAfterDisable`: Shut down when maintenance mode is enabled and restart the VM after maintenance mode is disabled. The VM will stay on the same node. - `Shutdown`: Shut down when maintenance mode is enabled. Do NOT restart the VM, it remains switched off. If the `Force` checkbox is selected in the maintenance dialog, a configured maintenance mode strategy of a VM is overridden and it is shut down and remains off regardless of the configured strategy. For all other VMs that do not have the label `harvesterhci.io/maintain-mode-strategy`, the current behavior of the forced maintenance mode is applied. Related to: harvester#5069 HEP: harvester#5984 Docs: harvester/docs#523 Signed-off-by: Volker Theile <vtheile@suse.com>
bk201
pushed a commit
to harvester/harvester
that referenced
this pull request
Jul 5, 2024
Introduce the label `harvesterhci.io/maintain-mode-strategy` which can be added to a `VirtualMachine` resource to specify the behaviour of the VM in case of a node maintenance event. The following modes are supported: - `Migrate` (default): The VM will be live-migrated to another node in the cluster. This is the behavior of the maintenance feature as it is at the moment and will be default with this enhancement. - `ShutdownAndRestartAfterEnable`: Shut down and restart the VM after maintenance mode is enabled. The VM will be scheduled on a different node. - `ShutdownAndRestartAfterDisable`: Shut down when maintenance mode is enabled and restart the VM after maintenance mode is disabled. The VM will stay on the same node. - `Shutdown`: Shut down when maintenance mode is enabled. Do NOT restart the VM, it remains switched off. If the `Force` checkbox is selected in the maintenance dialog, a configured maintenance mode strategy of a VM is overridden and it is shut down and remains off regardless of the configured strategy. For all other VMs that do not have the label `harvesterhci.io/maintain-mode-strategy`, the current behavior of the forced maintenance mode is applied. Related to: #5069 HEP: #5984 Docs: harvester/docs#523 Signed-off-by: Volker Theile <vtheile@suse.com>
bk201
pushed a commit
to bk201/harvester
that referenced
this pull request
Jul 5, 2024
Introduce the label `harvesterhci.io/maintain-mode-strategy` which can be added to a `VirtualMachine` resource to specify the behaviour of the VM in case of a node maintenance event. The following modes are supported: - `Migrate` (default): The VM will be live-migrated to another node in the cluster. This is the behavior of the maintenance feature as it is at the moment and will be default with this enhancement. - `ShutdownAndRestartAfterEnable`: Shut down and restart the VM after maintenance mode is enabled. The VM will be scheduled on a different node. - `ShutdownAndRestartAfterDisable`: Shut down when maintenance mode is enabled and restart the VM after maintenance mode is disabled. The VM will stay on the same node. - `Shutdown`: Shut down when maintenance mode is enabled. Do NOT restart the VM, it remains switched off. If the `Force` checkbox is selected in the maintenance dialog, a configured maintenance mode strategy of a VM is overridden and it is shut down and remains off regardless of the configured strategy. For all other VMs that do not have the label `harvesterhci.io/maintain-mode-strategy`, the current behavior of the forced maintenance mode is applied. Related to: harvester#5069 HEP: harvester#5984 Docs: harvester/docs#523 Signed-off-by: Volker Theile <vtheile@suse.com> (cherry picked from commit d4166eb)
|
bk201
pushed a commit
to harvester/harvester
that referenced
this pull request
Jul 5, 2024
Introduce the label `harvesterhci.io/maintain-mode-strategy` which can be added to a `VirtualMachine` resource to specify the behaviour of the VM in case of a node maintenance event. The following modes are supported: - `Migrate` (default): The VM will be live-migrated to another node in the cluster. This is the behavior of the maintenance feature as it is at the moment and will be default with this enhancement. - `ShutdownAndRestartAfterEnable`: Shut down and restart the VM after maintenance mode is enabled. The VM will be scheduled on a different node. - `ShutdownAndRestartAfterDisable`: Shut down when maintenance mode is enabled and restart the VM after maintenance mode is disabled. The VM will stay on the same node. - `Shutdown`: Shut down when maintenance mode is enabled. Do NOT restart the VM, it remains switched off. If the `Force` checkbox is selected in the maintenance dialog, a configured maintenance mode strategy of a VM is overridden and it is shut down and remains off regardless of the configured strategy. For all other VMs that do not have the label `harvesterhci.io/maintain-mode-strategy`, the current behavior of the forced maintenance mode is applied. Related to: #5069 HEP: #5984 Docs: harvester/docs#523 Signed-off-by: Volker Theile <vtheile@suse.com> (cherry picked from commit d4166eb)
Related to: harvester/harvester#5069 Co-authored-by: Jillian <67180770+jillian-maroket@users.noreply.github.com> Signed-off-by: Volker Theile <vtheile@suse.com>
votdev
force-pushed
the
issue_5069_improve_maintenance_mode
branch
from
9dbb8a2
to
e60b32b
Compare
jillian-maroket
approved these changes
Aug 15, 2024
FrankYang0529
approved these changes
Sep 2, 2024
|
@Mergifyio backport v1.4 |
❌ No backport have been created
GitHub error: |
bk201
approved these changes
Sep 2, 2024
|
@votdev there is no need to backport a doc PR to other branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: harvester/harvester#5069