Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional-guest-memory-overhead-ratio setting #615

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

w13915984028
Copy link
Member

@w13915984028 w13915984028 commented Jul 26, 2024

Issue:

harvester/harvester#5768

harvester/harvester#6293 (about the influence of memory overhead against resource quota)

Copy link

github-actions bot commented Jul 26, 2024

Name Link
🔨 Latest commit d1f89cc
😎 Deploy Preview https://66f15dd3a568a7f301024e12--harvester-preview.netlify.app

Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review done

docs/vm/create-vm.md Outdated Show resolved Hide resolved
docs/vm/create-vm.md Outdated Show resolved Hide resolved
docs/vm/create-vm.md Outdated Show resolved Hide resolved
@w13915984028
Copy link
Member Author

@jillian-maroket The original PR was titled with WIP as it was still in progress. Now the PR is ready for review, please take a new look, thanks.

Signed-off-by: Jian Wang <jian.wang@suse.com>
Signed-off-by: Jian Wang <jian.wang@suse.com>
Signed-off-by: Jian Wang <jian.wang@suse.com>
@w13915984028
Copy link
Member Author

The comment from code review by @bk201 is worthy to check, it is better to have some benchmarks to support our suggestions on the document.

harvester/harvester#6438 (review)

Signed-off-by: Jian Wang <jian.wang@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants