Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(ccm): state that lb feature requires macvlan #632

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

starbops
Copy link
Member

@starbops starbops commented Aug 27, 2024

DHCP mode load balancer services require the macvlan kernel module to function correctly. This kernel module must be present in the virtual machines that make up the guest cluster. If it is not, we provide guidance on how users can customize their cloud images accordingly.

Related issue: harvester/harvester#6418

Copy link

github-actions bot commented Aug 27, 2024

Name Link
🔨 Latest commit a8498df
😎 Deploy Preview https://66d6bd24fd9120d995f42d44--harvester-preview.netlify.app

Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on tech side

@starbops
Copy link
Member Author

I added SLES 15 SP5 as it does not have the macvlan kernel module either.

@starbops starbops force-pushed the fix-6418 branch 2 times, most recently from 55afa27 to 2b4fe65 Compare August 28, 2024 00:41
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have concerns about the changes.

docs/rancher/cloud-provider.md Outdated Show resolved Hide resolved
docs/rancher/cloud-provider.md Outdated Show resolved Hide resolved
docs/rancher/cloud-provider.md Outdated Show resolved Hide resolved
Signed-off-by: Zespre Chang <zespre.chang@suse.com>
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants