Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upgrade-config setting restoreVM document #641

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add upgrade-config setting restoreVM document #641

wants to merge 2 commits into from

Conversation

brandboat
Copy link

related to harvester/harvester#4005, add doc for new upgrade-config setting, restoreVM.

@brandboat
Add upgrade-config setting restoreVM document
41132ee 
Signed-off-by: Cooper Tseng <cooper.tseng@suse.com>
@brandboat brandboat mentioned this pull request Sep 18, 2024
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

Name Link
🔨 Latest commit 8544ed0
😎 Deploy Preview https://66ed3ca2fe793626f13b861c--harvester-preview.netlify.app

jillian-maroket
jillian-maroket reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have concerns about the changes.

docs/advanced/settings.md Outdated Show resolved Hide resolved
docs/advanced/singlenodeclusters.md Outdated Show resolved Hide resolved
starbops
starbops approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in the tech aspect. Thank you.

jillian-maroket
jillian-maroket approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@jillian-maroket jillian-maroket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starbops starbops starbops approved these changes

@jillian-maroket jillian-maroket jillian-maroket approved these changes

@bk201 bk201 Awaiting requested review from bk201

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandboat @starbops @jillian-maroket