doc(upgrade): auto image cleanup not working in some upgrade paths #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding notes about the automatic image cleanup issue for the following upgrade paths: - Upgrading from v1.3.1 to v1.3.2 - Upgrading from v1.2.2 to v1.3.1 Signed-off-by: Zespre Chang <zespre.chang@suse.com>
|
|
|
||
| ### 2. Automatic image cleanup is not functioning | ||
|
|
||
| Due to an incomplete image list packaged in the published ISO image, the automatic image cleanup procedure will not work when users upgrade Harvester from v1.2.2 to v1.3.1. This does not impact the Harvester upgrade as a whole. To clean up container images manually after the upgrade ends, please refer to the [script](https://github.com/harvester/upgrade-helpers/blob/main/bin/harv-purge-images.sh). For more information, see [issue #6620](https://github.com/harvester/harvester/issues/6620). |
There was a problem hiding this comment.
Suggested change
| Due to an incomplete image list packaged in the published ISO image, the automatic image cleanup procedure will not work when users upgrade Harvester from v1.2.2 to v1.3.1. This does not impact the Harvester upgrade as a whole. To clean up container images manually after the upgrade ends, please refer to the [script](https://github.com/harvester/upgrade-helpers/blob/main/bin/harv-purge-images.sh). For more information, see [issue #6620](https://github.com/harvester/harvester/issues/6620). | |
| Automatic image cleanup, which is part of the upgrade process, cannot be performed if an incomplete image list is packaged in the published Harvester ISO. This issue does not block the upgrade, and you can use a [script](https://github.com/harvester/upgrade-helpers/blob/main/bin/harv-purge-images.sh) to manually clean up container images after the upgrade is completed. For more information, see [issue #6620](https://github.com/harvester/harvester/issues/6620). |
There was a problem hiding this comment.
Sorry, I cannot tell the vibe of the suggested version here. I'll make my point: it's our oversight not to pack the image list in the ISO image. It's not the user's misoperation that causes the issue, and they're not expected to do anything to fix it. Also, only the affected upgrade paths will have this known issue updated in their respective documentation pages, so I think there's no need to generalize it by adding an "if." Please ignore the comment if I totally get your point wrong. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding notes about the automatic image cleanup issue for the following upgrade paths:
Related issue: harvester/harvester#6620