Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc(upgrade): auto image cleanup not working in some upgrade paths #644

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

doc(upgrade): auto image cleanup not working in some upgrade paths #644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/upgrade/v1-2-2-to-v1-3-1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,3 +87,9 @@ To resolve this issue, perform the following steps:
- [[BUG] Upgrade v1.2.2->v1.3.1 stuck at Waiting for kubelet to update, even the node has been updated](https://github.com/harvester/harvester/issues/6041)

---

### 2. Automatic image cleanup is not functioning

Due to an incomplete image list packaged in the published ISO image, the automatic image cleanup procedure will not work when users upgrade Harvester from v1.2.2 to v1.3.1. This does not impact the Harvester upgrade as a whole. To clean up container images manually after the upgrade ends, please refer to the [script](https://github.com/harvester/upgrade-helpers/blob/main/bin/harv-purge-images.sh). For more information, see [issue #6620](https://github.com/harvester/harvester/issues/6620).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Due to an incomplete image list packaged in the published ISO image, the automatic image cleanup procedure will not work when users upgrade Harvester from v1.2.2 to v1.3.1. This does not impact the Harvester upgrade as a whole. To clean up container images manually after the upgrade ends, please refer to the [script](https://github.com/harvester/upgrade-helpers/blob/main/bin/harv-purge-images.sh). For more information, see [issue #6620](https://github.com/harvester/harvester/issues/6620).
Automatic image cleanup, which is part of the upgrade process, cannot be performed if an incomplete image list is packaged in the published Harvester ISO. This issue does not block the upgrade, and you can use a [script](https://github.com/harvester/upgrade-helpers/blob/main/bin/harv-purge-images.sh) to manually clean up container images after the upgrade is completed. For more information, see [issue #6620](https://github.com/harvester/harvester/issues/6620).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I cannot tell the vibe of the suggested version here. I'll make my point: it's our oversight not to pack the image list in the ISO image. It's not the user's misoperation that causes the issue, and they're not expected to do anything to fix it. Also, only the affected upgrade paths will have this known issue updated in their respective documentation pages, so I think there's no need to generalize it by adding an "if." Please ignore the comment if I totally get your point wrong. Thank you.


---
6 changes: 6 additions & 0 deletions docs/upgrade/v1-3-1-to-v1-3-2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,3 +220,9 @@ If the kubectl command does not return a response, the kubelet is unable to acce
For more information, see [Issue #6432](https://github.com/harvester/harvester/issues/6432#issuecomment-2325488465).

---

### 2. Automatic image cleanup is not functioning

Due to an incomplete image list packaged in the published ISO image, the automatic image cleanup procedure will not work when users upgrade Harvester from v1.3.1 to v1.3.2. This does not impact the Harvester upgrade as a whole. To clean up container images manually after the upgrade ends, please refer to the [script](https://github.com/harvester/upgrade-helpers/blob/main/bin/harv-purge-images.sh). For more information, see [issue #6620](https://github.com/harvester/harvester/issues/6620).

---
6 changes: 6 additions & 0 deletions versioned_docs/version-v1.3/upgrade/v1-2-2-to-v1-3-1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,3 +87,9 @@ To resolve this issue, perform the following steps:
- [[BUG] Upgrade v1.2.2->v1.3.1 stuck at Waiting for kubelet to update, even the node has been updated](https://github.com/harvester/harvester/issues/6041)

---

### 2. Automatic image cleanup is not functioning

Due to an incomplete image list packaged in the published ISO image, the automatic image cleanup procedure will not work when users upgrade Harvester from v1.2.2 to v1.3.1. This does not impact the Harvester upgrade as a whole. To clean up container images manually after the upgrade ends, please refer to the [script](https://github.com/harvester/upgrade-helpers/blob/main/bin/harv-purge-images.sh). For more information, see [issue #6620](https://github.com/harvester/harvester/issues/6620).

---
6 changes: 6 additions & 0 deletions versioned_docs/version-v1.3/upgrade/v1-3-1-to-v1-3-2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,3 +220,9 @@ If the kubectl command does not return a response, the kubelet is unable to acce
For more information, see [Issue #6432](https://github.com/harvester/harvester/issues/6432#issuecomment-2325488465).

---

### 2. Automatic image cleanup is not functioning

Due to an incomplete image list packaged in the published ISO image, the automatic image cleanup procedure will not work when users upgrade Harvester from v1.3.1 to v1.3.2. This does not impact the Harvester upgrade as a whole. To clean up container images manually after the upgrade ends, please refer to the [script](https://github.com/harvester/upgrade-helpers/blob/main/bin/harv-purge-images.sh). For more information, see [issue #6620](https://github.com/harvester/harvester/issues/6620).

---