Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable iptables bridge forwarding on initialization #83

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

yaocw2020
Copy link
Contributor

@yaocw2020 yaocw2020 commented May 23, 2023

Problem:

In the Harvester cluster whose management network has a VLAN ID, the VM will be unable to access the host port or node port with the host IP where the VM is running.

Solution:

Disable net.bridge.bridge-nf-call-iptables to avoid iptables rules affecting bridge forwarding on vlan.init().

We could not disable net.bridge.bridge-nf-call-iptables in the harvester-installer because RKE2 will enable it after harvester-installer.

Related Issue: harvester/harvester#3960

Test plan:

  • Spin up a Harvester whose management network has a VLAN ID
  • Create a VM with VLAN network whose VLAN ID is same with the management network.
  • Curl nodeIP:443 in the VM.

@iosifnicolae2
Copy link

Isn't disabling net.bridge.bridge-nf-call-iptables a security risk?

Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It works fine with the current Harvester design/implementation. However, I'm unsure of its impact on future network policy-relevant features with either NeuVector or Harvester's own solution (like the one mentioned in the SecurityGroups HEP).

Copy link
Contributor

@mingshuoqiu mingshuoqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree to @starbops. The issue #3960 also need to disable it.

@bk201 bk201 merged commit 6521629 into harvester:master Sep 18, 2024
@bk201
Copy link
Member

bk201 commented Sep 19, 2024

@Mergifyio backport v0.5.x

Copy link

mergify bot commented Sep 19, 2024

backport v0.5.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants