Add lvm provisioner #128
Merged
Add lvm provisioner #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vicente-Cheng
force-pushed
the
add-lvm-provisioner
branch
2 times, most recently
from
abe41ff
to
f83ecd5
Compare
|
codeFactor complains about the generated code. Please ignore that. |
Vicente-Cheng
force-pushed
the
add-lvm-provisioner
branch
from
f83ecd5
to
097bf8c
Compare
bk201
reviewed
Sep 9, 2024
bk201
reviewed
Sep 9, 2024
votdev
reviewed
Sep 9, 2024
votdev
reviewed
Sep 9, 2024
votdev
reviewed
Sep 9, 2024
deploy/charts/harvester-node-disk-manager/templates/crds/harvesterhci.io_lvmvolumegroups.yaml
Outdated
Show resolved
Hide resolved
votdev
reviewed
Sep 9, 2024
votdev
reviewed
Sep 9, 2024
votdev
reviewed
Sep 9, 2024
Vicente-Cheng
force-pushed
the
add-lvm-provisioner
branch
from
097bf8c
to
0fec916
Compare
tserong
reviewed
Sep 10, 2024
Vicente-Cheng
force-pushed
the
add-lvm-provisioner
branch
from
0fec916
to
379b9e8
Compare
- Also move types.go to blockdevice.go - Add new field `spec.provisioned` Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Vicente-Cheng
force-pushed
the
add-lvm-provisioner
branch
2 times, most recently
from
4f4cb86
to
bbd213e
Compare
bk201
reviewed
Sep 11, 2024
Vicente-Cheng
force-pushed
the
add-lvm-provisioner
branch
from
bbd213e
to
95ee809
Compare
tserong
reviewed
Sep 11, 2024
There was a problem hiding this comment.
I did a build of this and gave it a quick test on a single node cluster with two extra disks, and it works nicely (I provisioned and unprovisioned both disks to the same VG and it looks like it's behaving correctly).
Regarding the NotFoundError, it might be preferable to import "k8s.io/apimachinery/pkg/api/errors" then call errors.NewNotFound(...) to create the error, and errors.IsNotFound() to check it, rather than having our own error variable. If that makes sense, you can ignore my comments below regarding error variable naming and import paths :-)
- Now we could use the following fields to provision the volume group
```
Spec:
provisioner:
lvm:
vgName: vg001
```
- Introduce the new field to trigger provision
```
Spec:
provision: true
```
- The new CRD lvmvgs is introduced, this will contain the node info
and the volume group information.
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
Vicente-Cheng
force-pushed
the
add-lvm-provisioner
branch
from
95ee809
to
884615d
Compare
|
@Mergifyio backport v0.7.x |
✅ Backports have been created
|
This was referenced Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Add LVM provisioner
Solution:
Add LVM provisioner
Related Issue:
harvester/harvester#6014
harvester/harvester#5724
Test plan:
TBD