Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make sure the if-condition works #143

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

Vicente-Cheng
Copy link
Collaborator

@Vicente-Cheng Vicente-Cheng commented Sep 26, 2024

Problem:
The CI teardown flow is not working.

Need always() to trigger the steps, or steps after the failure cannot be executed.

Solution:
Make sure the if-condition works

Related Issue:

Test plan:

@Vicente-Cheng Vicente-Cheng marked this pull request as draft September 26, 2024 17:36
@Vicente-Cheng Vicente-Cheng force-pushed the improve-the-teradown branch 2 times, most recently from 5f66d43 to 6d3e33b Compare September 26, 2024 18:14
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
@Vicente-Cheng Vicente-Cheng marked this pull request as ready for review September 26, 2024 18:54
Copy link
Contributor

@tserong tserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I wonder -- could we instead remove the if line entirely? Would that also work to make these steps run?

@Vicente-Cheng
Copy link
Collaborator Author

LGTM, although I wonder -- could we instead remove the if line entirely? Would that also work to make these steps run?

Sure, that's the original behavior.
With always() but no check.

So I would get some error log from getting NDM log or vagrant destroy
I would like to cleanup these errors.

@Vicente-Cheng
Copy link
Collaborator Author

@Mergifyio backport v0.7.x v0.6.x

Copy link

mergify bot commented Sep 27, 2024

backport v0.7.x v0.6.x

✅ Backports have been created

@Vicente-Cheng Vicente-Cheng merged commit 78e0d91 into harvester:master Sep 27, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants