scanner: correct the autoProvision mechanism (backport #147) #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
- we should not set both `Spec.Filesystem.Provisioned` and
`Spec.Provision` or the remove operation would be blocked if
we only change one of these to false.
This is a side-effect that comes from 1877a4e.
For now, we will remove one of these two fields to ensure the delete operation
work. We still need mutator to help convert these two fields.
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
(cherry picked from commit d5b7347)
tserong
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The removal operation would be blocked if we only changed one of these to false.
Solution:
For now, we will remove one of these two fields to ensure the delete operation work.
Related Issue:
Test plan:
This is an automatic backport of pull request #147 done by [Mergify](https://mergify.com).