Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert sriov device name objects to lowercase #88

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

ibrokethecloud
Copy link
Collaborator

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Problem:

In certain cases nic names may have uppercase characters. This can cause failures in the pcidevices controller when it attempts to setup the sriov network devices.

Solution:

The fix is to convert sriov network device names to lowercase.

Related Issue:
harvester/harvester#6502
Test plan:

Copy link
Contributor

@Yu-Jack Yu-Jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@WebberHuang1118 WebberHuang1118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@WebberHuang1118 WebberHuang1118 merged commit c0733b4 into harvester:master Sep 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants