ci: move from drone ci to github actions #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yu-Jack
reviewed
Apr 24, 2024
bk201
reviewed
Apr 24, 2024
|
The local build path using |
Yu-Jack
reviewed
Apr 25, 2024
|
One more question, do we need artifact folder here? |
Besides the CI migration, the golangci-lint version is bumped and added a timeout flag for execution. Signed-off-by: Zespre Chang <zespre.chang@suse.com>
It seems like a legacy to me. I removed them entirely from the package scripts. I also added a new consolidated |
Yu-Jack
requested changes
Apr 25, 2024
Signed-off-by: Zespre Chang <zespre.chang@suse.com>
bk201
approved these changes
Apr 25, 2024
|
Waiting for rancherlabs/eio#2205. Please do not merge yet. Update: the secrets were migrated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:
We're going to transfer to GitHub Actions from Drone CI.
Solution:
Migrate pipelines originally defined in
.drone.ymlto GitHub Actions workflows.Besides the CI migration, the golangci-lint version is bumped and added a timeout flag for execution.
Related Issue:
harvester/harvester#5327
Test plan: