Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContractCreateFlow creates a file for smaller initcode #1746

Open
steven-sheehy opened this issue Mar 6, 2024 · 0 comments · May be fixed by #1832
Open

ContractCreateFlow creates a file for smaller initcode #1746

steven-sheehy opened this issue Mar 6, 2024 · 0 comments · May be fixed by #1832
Assignees
Labels
enhancement New feature or request

Comments

@steven-sheehy
Copy link
Member

steven-sheehy commented Mar 6, 2024

Problem

The ContractCreateFlow does not take advantage of newer features of HAPI to reduce the number and cost of transactions. Same issue in all SDKs.

Solution

  • The initcode file is created unconditionally instead of directly using ContractCreateTransaction.bytecode if it fits within a single transaction. File append and delete would likewise not be needed if bytecode is populated.
  • FileCreateTransaction partial bytecode is limited to 2048 instead of a larger size closer to max HAPI size 6 KiB
  • FileAppendTransaction sets chunk size to 2048 instead of a size closer to max HAPI size 6 KiB

Alternatives

No response

@steven-sheehy steven-sheehy added the enhancement New feature or request label Mar 6, 2024
@SimiHunjan SimiHunjan added this to the 2.34.0 milestone May 29, 2024
@thenswan thenswan linked a pull request May 30, 2024 that will close this issue
@SimiHunjan SimiHunjan modified the milestones: 2.34.0, 2.35.0 Jun 11, 2024
@SimiHunjan SimiHunjan removed this from the 2.35.0 milestone Jun 25, 2024
@Petyo-Lukanov Petyo-Lukanov added this to the 2.36.0 milestone Jul 19, 2024
@SimiHunjan SimiHunjan modified the milestones: v2.36.0, v2.37.0 Jul 23, 2024
@Petyo-Lukanov Petyo-Lukanov modified the milestones: v2.37.0, v2.38.0 Aug 6, 2024
@SimiHunjan SimiHunjan removed this from the v2.38.0 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants