Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): Add test with scp operations #3812

Merged
merged 3 commits into from
Oct 10, 2023
Merged

Conversation

moduli
Copy link
Collaborator

@moduli moduli commented Oct 9, 2023

This PR adds an e2e test that validates scp operations over a boundary connection. The test does the following

  • creates a tcp target
  • connects to the target
  • generates a text file of ~300K
  • scp the file from the client to the target. validates the checksum
  • cat the file on the target
  • scp the file from the target to the client. validates the checksum

There will be a follow-up PR to do the same for an ssh target.

@moduli moduli added the pr/no-milestone Ignores the Milestone Check label Oct 9, 2023
@moduli moduli marked this pull request as ready for review October 9, 2023 16:12
@moduli moduli force-pushed the moduli-e2e-scp-test-ICU-11291 branch from e484592 to 486e4ec Compare October 9, 2023 16:15
@moduli moduli requested a review from louisruch October 9, 2023 16:48
@moduli
Copy link
Collaborator Author

moduli commented Oct 9, 2023

As a note, when working on the ssh target variant of the test, it is currently failing when trying to cat the text file on the target, as expected.

EDIT: I'm a little confused. The ssh target version of the test fails when running this locally against AWS or Docker infrastructure. However, it somehow passed in CI (against Docker infrastructure)???

EDIT2: I needed to update my CLI locally

@moduli moduli force-pushed the moduli-e2e-scp-test-ICU-11291 branch from 486e4ec to 35a0c8c Compare October 10, 2023 13:32
This mitigates the need to allocate a 256K string
@moduli moduli merged commit 578d870 into main Oct 10, 2023
57 checks passed
@moduli moduli deleted the moduli-e2e-scp-test-ICU-11291 branch October 10, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/no-milestone Ignores the Milestone Check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants