From 5085c2b6721c06e26564434df220dfd19387e4ac Mon Sep 17 00:00:00 2001 From: Tim Gross Date: Wed, 2 Oct 2024 09:39:12 -0400 Subject: [PATCH] build: update go toolchain to 1.23.2 Picks up some small bug fixes but one especially relevant to Nomad is the `os/exec` file descriptor, which could impact script check / change mode for task drivers without isolated exec (ex. `raw_exec`). Ref: https://github.com/golang/go/issues?q=milestone%3AGo1.23.2+label%3ACherryPickApproved Ref: https://github.com/golang/go/issues/69402 --- .go-version | 2 +- contributing/README.md | 2 +- scripts/linux-priv-go.sh | 2 +- scripts/release/mac-remote-build | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.go-version b/.go-version index 49e0a31d496..14bee92c9e7 100644 --- a/.go-version +++ b/.go-version @@ -1 +1 @@ -1.23.1 +1.23.2 diff --git a/contributing/README.md b/contributing/README.md index 1778c56fe96..f6440ff0bba 100644 --- a/contributing/README.md +++ b/contributing/README.md @@ -33,7 +33,7 @@ A development environment is supplied via Vagrant to make getting started easier Developing without Vagrant --- -1. Install [Go 1.23.1+](https://golang.org/) *(Note: `gcc-go` is not supported)* +1. Install [Go 1.23.2+](https://golang.org/) *(Note: `gcc-go` is not supported)* 1. Clone this repo ```sh $ git clone https://github.com/hashicorp/nomad.git diff --git a/scripts/linux-priv-go.sh b/scripts/linux-priv-go.sh index 29b86a21611..8e07cf655a5 100755 --- a/scripts/linux-priv-go.sh +++ b/scripts/linux-priv-go.sh @@ -21,7 +21,7 @@ case $(arch) in esac function install_go() { - local go_version="1.23.1" + local go_version="1.23.2" local download="https://storage.googleapis.com/golang/go${go_version}.linux-${ARCH}.tar.gz" if go version 2>&1 | grep -q "${go_version}"; then diff --git a/scripts/release/mac-remote-build b/scripts/release/mac-remote-build index 4b2609437e9..878731e69b0 100755 --- a/scripts/release/mac-remote-build +++ b/scripts/release/mac-remote-build @@ -56,7 +56,7 @@ REPO_PATH="${TMP_WORKSPACE}/gopath/src/github.com/hashicorp/nomad" mkdir -p "${TMP_WORKSPACE}/tmp" install_go() { - local go_version="1.23.1" + local go_version="1.23.2" local download= download="https://storage.googleapis.com/golang/go${go_version}.darwin-amd64.tar.gz"