-
Notifications
You must be signed in to change notification settings - Fork 465
sign-request.py is not compatible with python 3.x #148
Comments
This appears to be an issue with running against python 3.x in Python 2.x, in Python 3.x, it takes a bytes object I'm not sure what the best approach is for making it compatible with both, but here's how I got it working in python 3.x:
also had to change
probably some more changes too... I'll log them here as I find them |
I think it's okay if it's py 3 only. PRs welcome! :) |
What about adding a separate py3 version of the file ( I agree that we shouldn't try to make the existing file py2 + 3 compatible because without |
okay, it needed a few more tweaks, but here's a version for 3.x: https://gist.github.com/eedwards-sk/161e98844db85919f6a85a3f7dce58f7 please feel free to toss into a PR or we could use this to figure out a 3.x/2.x compatible version |
see https://github.com/hashicorp/terraform-aws-vault/blob/master/examples/vault-consul-ami/auth/sign-request.py#L43
The text was updated successfully, but these errors were encountered: