Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go Module to Go 1.20 Minimum #413

Closed
1 task done
bendbennett opened this issue Sep 8, 2023 · 2 comments · Fixed by #414
Closed
1 task done

Update Go Module to Go 1.20 Minimum #413

bendbennett opened this issue Sep 8, 2023 · 2 comments · Fixed by #414
Labels
dependencies go Pull requests that update Go code
Milestone

Comments

@bendbennett
Copy link
Contributor

Terraform CLI and Provider Versions

v4.0.4

Use Cases or Problem Statement

Following the Go support policy and given the ecosystem availability of the latest Go minor version, it's time to upgrade. This will ensure that this project can use recent improvements to the Go runtime, standard library functionality, and continue to receive security updates.

Proposal

  • Run the following commands to upgrade the Go module files and automatically fix outdated Go code:
go mod edit -go=1.20
go mod tidy
go fix ./...
cd tools
go mod edit -go=1.20
go mod tidy
  • Ensure any GitHub Actions workflows (.github/workflows/*.yml) use 1.21 in place of any 1.20 and 1.20 in place of any 1.19 or earlier
  • Ensure the README or any Contributing documentation notes the Go 1.20 expected minimum

How much impact is this issue causing?

Low

Additional Information

References

Code of Conduct

  • I agree to follow this project's Code of Conduct
@bendbennett bendbennett added dependencies go Pull requests that update Go code labels Sep 8, 2023
@bendbennett bendbennett added this to the v4.1.0 milestone Sep 8, 2023
bendbennett added a commit that referenced this issue Sep 8, 2023
@dolevf
Copy link

dolevf commented Sep 8, 2023

Hi there,

Can we expect a new release following this change?

We have a few CVEs we would like to address, but we're waiting on a new release that will include them.

Thank you so much

bendbennett added a commit that referenced this issue Sep 11, 2023
* all: Update Go Module to Go 1.20 (#413)

* Remove changelog entry (#413)
@austinvalle austinvalle modified the milestones: v4.1.0, v4.0.5 Nov 27, 2023
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies go Pull requests that update Go code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants